1853270 - Add LordUrlFlag flag to allow additional headers

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Currently, any additional headers that is passed into GeckoEngineSession.kt#197 are filtered out if they are not CORS safelisted. We want to add a LoadUrlFlag flag that will allow additional headers to be sent.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1853270 - Add LordUrlFlag flag to allow additional headers (#3658)

Comment 2

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/c2e2e9b662543ef5e49a667bc6b7184123388537
[main] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers (backport #3658) (#3734)

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9354327 [details] [review]
[mozilla-mobile/firefox-android] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers (backport #3658) (#3734)

Beta/Release Uplift Approval Request

• User impact if declined: Google Tier 1 search experiment will be delayed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds a new flag that needs to be manually set to allow additional headers to be sent when loading a new URL because this flag is only used in very specific controlled use cases that we have to set - this change is not risky on its own.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9354327 [details] [review]
[mozilla-mobile/firefox-android] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers (backport #3658) (#3734)

118 is release now.

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9354327 [details] [review]
[mozilla-mobile/firefox-android] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers (backport #3658) (#3734)

Approved for 118 RC2

Comment 7

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/77edc0f78eed9bbf6a94773835beb39ef630f4d6
[releases_v118] Bug 1853270 - Add LoadUrlFlag flag to allow additional headers