1853271 - Make |mach configure| prefer Mozilla's clang to local clang

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Back when bug 1519954 was fixed, the tradeoff that was made was that only developer builds would prioritize bootstrapped things by default.

Things have evolved, and this behavior is annoying to more people than not. We also now have a knob that could be used to explicitly disable this behavior (as opposed to a side effect of --enable-release): --disable-bootstrap.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1853271 - Make `mach configure` prefer bootstrapped toolchains.

Except when bootstrap is explicitly disabled. This means that on
--enable-release builds, we would now prefer previously bootstrapped
toolchains (but wouldn't bootstrap by default if they aren't there)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddccd40117a0
Make `mach configure` prefer bootstrapped toolchains. r=firefox-build-system-reviewers,sergesanspaille,nalexander

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ddccd40117a0

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bug 1854769 - autoland

• backout: https://hg.mozilla.org/integration/autoland/rev/583cfd323dab818e35dc1f15fa3e92a503e56e11

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bug 1854769 - beta

• backout: https://hg.mozilla.org/releases/mozilla-beta/rev/32c9429bb1b909628b4702be4abf30d1c8ef9213

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)

Things have evolved, and this behavior is annoying to more people than not. We also now have a knob that could be used to explicitly disable this behavior (as opposed to a side effect of --enable-release): --disable-bootstrap.

This needs some more thought considering bug 1854769.

Comment 7

[Cosmin Sabou [:CosminS]]

Backout merged to mozilla-central: https://hg.mozilla.org/mozilla-central/rev/583cfd323dab

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Nick Alexander :nalexander [he/him]]

This is in Mike's court.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1acdcb0c63c
Make `mach configure` prefer bootstrapped toolchains. r=firefox-build-system-reviewers,sergesanspaille,nalexander

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c1acdcb0c63c