1853323 - Consider removing "Underline links" from the color dialog

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This removes a global selector and some complexity from the UA sheet, and in general since there's no way to also enforce it it doesn't work consistently.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1853323 - Remove browser.underline_anchors. r=#settings-reviewers!,morgan,eeejay

This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.

This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).

Just move this to the UA sheet properly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eaf1c80eff2
Remove browser.underline_anchors. r=settings-reviewers,mconley

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8eaf1c80eff2

Comment 4

[Morgan Reschenberg [:morgan]]

As discussed on matrix, can you please revert this so Eitan and I can finish our HCM user study?

Thank you :)

Comment 5

[Morgan Reschenberg [:morgan]]

On second thought, measuring this probably doesn't give us anything definitive since the preference was on by default (and, though it works on basic sites it doesn't override author css on more complex ones).
We should probably look to address bug 1664278 by adding a new pref in a different about:prefs location.