Closed Bug 1853323 Opened 8 months ago Closed 8 months ago

Consider removing "Underline links" from the color dialog

Categories

(Firefox :: Settings UI, defect)

defect

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

This removes a global selector and some complexity from the UA sheet, and in general since there's no way to also enforce it it doesn't work consistently.

This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.

This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).

Just move this to the UA sheet properly.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8eaf1c80eff2
Remove browser.underline_anchors. r=settings-reviewers,mconley
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Blocks: 1853519
Blocks: 1857915

As discussed on matrix, can you please revert this so Eitan and I can finish our HCM user study?

Thank you :)

Flags: needinfo?(emilio)
See Also: → 1664278

On second thought, measuring this probably doesn't give us anything definitive since the preference was on by default (and, though it works on basic sites it doesn't override author css on more complex ones).
We should probably look to address bug 1664278 by adding a new pref in a different about:prefs location.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: