1853444 - Add support for getting and setting sendOrder for WebTransport streams

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

The WebTransport WG recently added dynamic getting and setting of SendOrder; this is to support that. A patch to add it to the WPTs is under review currently

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1853444: Set/Get SendOrder for WebTransportSendStreams r=kershaw!

Allow dynamic changes to steram sendOrder to comply with updated
spec.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

We'll land this once we've vendored neqo

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Kershaw Chang [:kershaw]]

We'll land this when new neqo is ready.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a47a1ff34d2a
Set/Get SendOrder for WebTransportSendStreams r=kershaw,necko-reviewers,webidl,smaug

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on /webtransport/

• backout: https://hg.mozilla.org/integration/autoland/rev/78f4c5f1ff2dc9c5d2a31bccccf531a260953f36
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=a47a1ff34d2acacb8dbecf60ca5191d238db1f3e
• push where the failures appeared: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=RgEgk52zSgeXqoBVUrouXg.0&revision=277907757ae0f5c9f9a9b4b15473ec6f3eab7674&searchStr=wpt
• failure log: https://treeherder.mozilla.org/logviewer?job_id=434308885&repo=autoland&lineNumber=20993

[task 2023-10-30T19:02:54.719Z] 19:02:54     INFO - TEST-START | /webtransport/sendorder.https.any.sharedworker.html
[task 2023-10-30T19:02:54.760Z] 19:02:54     INFO - Closing window e9bb184a-ae79-4edb-892d-6dcf8e8c668e
[task 2023-10-30T19:02:58.906Z] 19:02:58  WARNING - wptserve cannot call write() after FIN
[task 2023-10-30T19:03:00.192Z] 19:03:00  WARNING - wptserve cannot call write() after FIN
[task 2023-10-30T19:03:00.193Z] 19:03:00  WARNING - wptserve cannot call write() after FIN
[task 2023-10-30T19:03:02.321Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.321Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport client should be able to create and handle a bidirectional stream with sendOrder - expected FAIL
[task 2023-10-30T19:03:02.321Z] 19:03:02     INFO - TEST-INFO | expected FAIL
[task 2023-10-30T19:03:02.322Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.323Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport client should be able to modify unset sendOrder after stream creation - expected FAIL
[task 2023-10-30T19:03:02.326Z] 19:03:02     INFO - TEST-INFO | expected FAIL
[task 2023-10-30T19:03:02.327Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.327Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport client should be able to modify existing sendOrder after stream creation - expected FAIL
[task 2023-10-30T19:03:02.327Z] 19:03:02     INFO - TEST-INFO | expected FAIL
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport sendorder should not starve a stream without sendorder - expected FAIL
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - TEST-INFO | expected FAIL
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport sendorder should starve a lower priority stream - expected FAIL
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - TEST-INFO | expected FAIL
[task 2023-10-30T19:03:02.330Z] 19:03:02     INFO - 
[task 2023-10-30T19:03:02.331Z] 19:03:02     INFO - TEST-UNEXPECTED-PASS | /webtransport/sendorder.https.any.sharedworker.html | WebTransport sendorder should starve a lower priority stream, variant 2 - expected FAIL
[task 2023-10-30T19:03:02.331Z] 19:03:02     INFO - TEST-INFO | expected FAIL

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ac3819ddc53
Set/Get SendOrder for WebTransportSendStreams r=kershaw,necko-reviewers,webidl,smaug

Comment 8

[Iulian Moraru]

Backed out for causing wpt failures on sendorder.https.any.js.
This fails in multiple subtests. If you want to see all the failures related to this backout, you can check this link.

• Push with failures

• Failure log

• Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c425a66740c6
Set/Get SendOrder for WebTransportSendStreams r=kershaw,necko-reviewers,webidl,smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43053 for changes under testing/web-platform/tests

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c425a66740c6

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

The patch removed some amount of WPT tests, was that intentional? I know you are investigating because of failures there, but I'd rather disable it via meta ini file rather than removing them, unless those tests are fully redundant 🤔

Comment 14

[Hamish Willee]

FF121 docs work for this done in https://github.com/mdn/content/issues/30481

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

I wrote that test which landed in an earlier patch; it isn't possible to reliably test in that way