1853588 - Port |Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, task)

Description

[Ian Neal]

Port to SeaMonkey:

• Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle
  This was done in Bug 1516367 for TB

Comment 1

[Ian Neal]

Attachment: 1853588-minidump-25318.patch

[Approval Request Comment]
Regression caused by (bug #): 1516367
User impact if declined: build breaks
Testing completed (on m-c, etc.): 2.53.18
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9353590 [details] [diff] [review]
1853588-minidump-25318.patch

LGTM

Comment 3

[Frank-Rainer Grahl (:frg)]

Before I check this in. How about removing the last endif from the old block and the new +#ifdef MOZ_CRASHREPORTER?

#endif
#endif

+; [ minidump-analyzer ]
+;
+#ifdef MOZ_CRASHREPORTER

Comment 4

[Frank-Rainer Grahl (:frg)]

Lets keep it as in the patch because of the new section.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4333b407e6ab
Port |Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle| to SeaMonkey. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2afda248148e80dd9f02275809f95d6c70a59cea
Port |Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle| to SeaMonkey. r=frg a=frg