Closed
Bug 1853627
Opened 1 year ago
Closed 1 year ago
Increase in ERROR_INTERNAL_ERROR reports on release 117
Categories
(Core :: Security: Process Sandboxing, defect)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
119 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox117 | --- | wontfix |
| firefox118 | --- | fixed |
| firefox119 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-release+
|
Details | Review |
Telemetry on LoadLibraryOrCrash reports an increase with error code ERROR_INTERNAL_ERROR on release 117: https://sql.telemetry.mozilla.org/queries/94596/source?p_channel=release#233772
I worry this is a consequence of bug 1843020 / bug 1842921
|
Assignee | |
Comment 1•1 year ago
•
|
||
There's also some increase on beta and nightly channels, but given the volume it's not as clear as on release
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → lissyx+mozillians
|
|
Assignee | |
Comment 2•1 year ago
•
|
||
Pushed to try win11 a simple test of audio decoder, after removing ole32.dll preload and we have a nice stack at WMF Shutdown:
[task 2023-09-19T06:04:28.553Z] 06:04:28 INFO - PROCESS-CRASH | application crashed [@ sandbox::AutoProtectMemory::RevertProtection] | ipc\glue\test\browser\browser.ini
[task 2023-09-19T06:04:28.553Z] 06:04:28 INFO - Process type: unknown
[task 2023-09-19T06:04:28.553Z] 06:04:28 INFO - Process pid: 2392
[task 2023-09-19T06:04:28.553Z] 06:04:28 INFO - Crash dump filename: C:\Users\task_169510259040070\AppData\Local\Temp\tmpcvo6cco2.mozrunner\minidumps\b8f23cdb-4373-49f3-9d40-9328c8724e2d.dmp
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - Operating system: Windows NT
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - 10.0.22621
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - CPU: x86
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - GenuineIntel family 6 model 106 stepping 6
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - 8 CPUs
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO -
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - Crash reason: EXCEPTION_BREAKPOINT
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - Crash address: 0x8903aa
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - Process uptime: 47 seconds
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO -
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - Thread 0 MainThread (crashed)
[task 2023-09-19T06:04:28.562Z] 06:04:28 INFO - 0 firefox.exe!sandbox::AutoProtectMemory::RevertProtection() [sandbox_nt_util.cc:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 622 + 0x4]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - eip = 0x008903aa esp = 0x051feee8 ebp = 0x051fef00 ebx = 0x051fef14
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - esi = 0x051fef08 edi = 0xc0000604 eax = 0xc0000604 ecx = 0x0c990000
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - edx = 0x74e11000 eflags = 0x00000282
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: given as instruction pointer in context
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 1 firefox.exe!sandbox::AutoProtectMemory::~AutoProtectMemory() [sandbox_nt_util.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 195]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 2 firefox.exe!sandbox::EatResolverThunk::Setup(void const*, void const*, char const*, char const*, void const*, void*, unsigned int, unsigned int*) [eat_resolver.cc:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 57 + 0x7]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - eip = 0x008764ba esp = 0x051fef08 ebp = 0x051fef28 ebx = 0x90780010
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - esi = 0x052804d8 edi = 0x00000000
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 3 firefox.exe!sandbox::InterceptionAgent::PatchDll(sandbox::DllPatchInfo const*, sandbox::DllInterceptionData*) [interception_agent.cc:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 179 + 0x40]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - eip = 0x0087edcc esp = 0x051fef30 ebp = 0x051fef80 ebx = 0x04d000c4
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - esi = 0x04d000e3 edi = 0x052804d8
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 4 firefox.exe!sandbox::InterceptionAgent::OnDllLoad(_UNICODE_STRING const*, _UNICODE_STRING const*, void*) [interception_agent.cc:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 127 + 0x9]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - eip = 0x0087ec75 esp = 0x051fef88 ebp = 0x051fefb4 ebx = 0x04d000a0
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - esi = 0x00000050 edi = 0x00000001
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 5 firefox.exe!TargetNtMapViewOfSection(long (*)(void*, void*, void**, unsigned long, unsigned long, _LARGE_INTEGER*, unsigned long*, unsigned long, unsigned long, unsigned long), void*, void*, void**, unsigned long, unsigned long, _LARGE_INTEGER*, unsigned long*, unsigned long, unsigned long, unsigned long) [target_interceptions.cc:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 97 + 0xa]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - eip = 0x00896e4f esp = 0x051fefbc ebp = 0x051ff000 ebx = 0x054aa960
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - esi = 0x05284008 edi = 0x052804b0
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - 6 firefox.exe!mozilla::interceptor::FuncHookCrossProcess<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyUnique<mozilla::interceptor::MMPolicyOutOfProcess> >,long (*)(void *, void *, void **, unsigned long, unsigned long, _LARGE_INTEGER *, unsigned long *, SECTION_INHERIT, unsigned long, unsigned long) __attribute__((stdcall))>::operator()(void*&, void*&, void**&, unsigned long&, unsigned long&, _LARGE_INTEGER*&, unsigned long*&, SECTION_INHERIT&, unsigned long&, unsigned long&) const [nsWindowsDllInterceptor.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 254]
[task 2023-09-19T06:04:28.563Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 7 firefox.exe!mozilla::freestanding::patched_NtMapViewOfSection(void*, void*, void**, unsigned long, unsigned long, _LARGE_INTEGER*, unsigned long*, SECTION_INHERIT, unsigned long, unsigned long) [DllBlocklist.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 578 + 0x29]
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x00840008 esp = 0x051ff008 ebp = 0x051ff088 ebx = 0xffffffff
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x0547ed60 edi = 0x00000000
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 8 ntdll.dll!LdrpMapViewOfSection + 0x76
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x76f1c94c esp = 0x051ff090 ebp = 0x051ff0d0 ebx = 0x051ff0d8
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 9 ntdll.dll!LdrpMinimalMapModule + 0xe3
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x76ed09da esp = 0x051ff0e0 ebp = 0x051ff120 ebx = 0x00800000
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 10 ntdll.dll!LdrpMapDllWithSectionHandle + 0x14
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x76ed06d6 esp = 0x051ff128 ebp = 0x051ff148 ebx = 0x00800000
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 11 ntdll.dll!LdrpLoadKnownDll + 0xd1
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x76ed661e esp = 0x051ff150 ebp = 0x051ff178 ebx = 0x00800000
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - 12 ntdll.dll!LdrpFindOrPrepareLoadingModule + 0xee
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - eip = 0x76eda02f esp = 0x051ff180 ebp = 0x051ff1a4 ebx = 0x00800000
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.564Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 13 ntdll.dll!LdrpLoadDllInternal + 0x1c7
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x76f1b091 esp = 0x051ff1ac ebp = 0x051ff204 ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 14 ntdll.dll!LdrpLoadForwardedDll + 0x11c
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x76ed6c1e esp = 0x051ff20c ebp = 0x051ff4a0 ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 15 ntdll.dll!LdrpGetDelayloadExportDll + 0x81
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x76ed5ec2 esp = 0x051ff4a8 ebp = 0x051ff53c ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 16 ntdll.dll!LdrpHandleProtectedDelayload + 0x78
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x76ed5a19 esp = 0x051ff544 ebp = 0x051ff7d8 ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 17 ntdll.dll!LdrResolveDelayLoadedAPI + 0x1e3
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x76ed47b4 esp = 0x051ff7e0 ebp = 0x051ff828 ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - 18 RTWorkQ.dll!__delayLoadHelper2 + 0x27
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - eip = 0x6159e973 esp = 0x051ff830 ebp = 0x051ff848 ebx = 0x00800000
[task 2023-09-19T06:04:28.565Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 19 RTWorkQ.dll!_tailMerge_api_ms_win_rtcore_ntuser_window_l1_1_0_dll + 0xc
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - eip = 0x6159fd4d esp = 0x051ff850 ebp = 0x051ff8a4 ebx = 0x00800000
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - esi = 0x000004f0 edi = 0x0547ed00
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 20 RTWorkQ.dll!void __thiscall CPlatform::Shutdown + 0x3c
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - eip = 0x61594f3d esp = 0x051ff8ac ebp = 0x051ff8d4
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: previous frame's frame pointer
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 21 RTWorkQ.dll!RtwqShutdown + 0x9
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - eip = 0x61594eea esp = 0x051ff8b8 ebp = 0x051ff8d4
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 22 mfplat.dll!MFShutdown + 0x25
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - eip = 0x61338066 esp = 0x051ff8bc ebp = 0x051ff8d4
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 23 xul.dll!mozilla::wmf::MediaFoundationInitializer::MFShutdown::<lambda_2>::operator()() const [WMFUtils.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 472]
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 24 xul.dll!mozilla::mscom::EnsureMTA::EnsureMTA(mozilla::wmf::MediaFoundationInitializer::MFShutdown::<lambda_2>&&, mozilla::mscom::EnsureMTA::Option) [EnsureMTA.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 66]
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 25 xul.dll!mozilla::wmf::MediaFoundationInitializer::MFShutdown() [WMFUtils.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 472 + 0x16]
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - eip = 0x68824cfd esp = 0x051ff8dc ebp = 0x051ff8f4
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 26 xul.dll!mozilla::wmf::MediaFoundationInitializer::~MediaFoundationInitializer() [WMF.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 68]
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - 27 xul.dll!mozilla::DefaultDelete<mozilla::wmf::MediaFoundationInitializer>::operator()(mozilla::wmf::MediaFoundationInitializer*) const [UniquePtr.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 459]
[task 2023-09-19T06:04:28.566Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 28 xul.dll!mozilla::UniquePtr<mozilla::wmf::MediaFoundationInitializer,mozilla::DefaultDelete<mozilla::wmf::MediaFoundationInitializer> >::reset(mozilla::wmf::MediaFoundationInitializer*) [UniquePtr.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 301]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 29 xul.dll!mozilla::wmf::MediaFoundationInitializer::Get::<lambda_1>::operator()::<lambda_1>::operator()() const [WMF.h:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 91]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 30 xul.dll!std::invoke(mozilla::wmf::MediaFoundationInitializer::Get::<lambda_1>::operator()::<lambda_1>&) [type_traits : 1524]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 31 xul.dll!std::_Invoker_ret<void,1>::_Call(mozilla::wmf::MediaFoundationInitializer::Get::<lambda_1>::operator()::<lambda_1>&) [functional : 651]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 32 xul.dll!std::_Func_impl_no_alloc<`lambda at /builds/worker/workspace/obj-build/dist/include/WMF.h:90:19',void>::_Do_call() [functional : 822 + 0x1f]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - eip = 0x65e46f94 esp = 0x051ff8fc ebp = 0x051ff900 esi = 0x05605158
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - edi = 0x654b5ae0
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 33 xul.dll!mozilla::KillClearOnShutdown(mozilla::ShutdownPhase) [ClearOnShutdown.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 55 + 0x11]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - eip = 0x65350a4b esp = 0x051ff908 ebp = 0x051ff914 esi = 0x05697840
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - edi = 0x654b5ae0
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 34 xul.dll!mozilla::AppShutdown::AdvanceShutdownPhaseInternal(mozilla::ShutdownPhase, bool, char16_t const*, nsCOMPtr<nsISupports> const&) [AppShutdown.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 416 + 0x5]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - eip = 0x653507ba esp = 0x051ff91c ebp = 0x051ff944 ebx = 0x00000001
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - esi = 0x00000008 edi = 0x0567ba00
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 35 xul.dll!mozilla::AppShutdown::AdvanceShutdownPhase(mozilla::ShutdownPhase, char16_t const*, nsCOMPtr<nsISupports> const&) [AppShutdown.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 456 + 0xf]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - eip = 0x65350bb3 esp = 0x051ff94c ebp = 0x051ff95c ebx = 0x00000000
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - esi = 0x051ff970 edi = 0x051ff9f0
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - 36 xul.dll!mozilla::ShutdownXPCOM(nsIServiceManager*) [XPCOMInit.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 603 + 0xf]
[task 2023-09-19T06:04:28.567Z] 06:04:28 INFO - eip = 0x654bfb83 esp = 0x051ff964 ebp = 0x051ffa10 ebx = 0x00000000
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x051ff970 edi = 0x051ff9f0
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 37 xul.dll!mozilla::ipc::UtilityProcessImpl::CleanUp() [UtilityProcessImpl.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 125 + 0x9]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - eip = 0x65e3a52a esp = 0x051ffa18 ebp = 0x051ffa1c ebx = 0x65e3a2c0
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x05604a60 edi = 0x65e3a520
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 38 xul.dll!XRE_InitChildProcess(int, char**, XREChildData const*) [nsEmbedFunctions.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 660 + 0x10]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - eip = 0x6b45a18f esp = 0x051ffa24 ebp = 0x051ffb78 ebx = 0x65e3a2c0
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x05604a60 edi = 0x65e3a520
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 39 xul.dll!mozilla::BootstrapImpl::XRE_InitChildProcess(int, char**, XREChildData const*) [Bootstrap.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 67 + 0xd]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - eip = 0x6b460e71 esp = 0x051ffb80 ebp = 0x051ffb8c ebx = 0x00000016
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x05605060 edi = 0x6b460e60
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 40 firefox.exe!content_process_main(mozilla::Bootstrap*, int, char**) [plugin-container.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 57]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 41 firefox.exe!NS_internal_main(int, char**, char**) [nsBrowserApp.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 375 + 0x8e]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - eip = 0x008214d4 esp = 0x051ffb94 ebp = 0x051ffcf4 ebx = 0x00000016
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x05605060 edi = 0x6b460e60
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 42 firefox.exe!wmain(int, wchar_t**) [nsWindowsWMain.cpp:9c81672e7cd7b15019455cbddf8112fddb0208d0 : 151 + 0x10]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - eip = 0x008211d5 esp = 0x051ffcfc ebp = 0x051ffd28 ebx = 0x05485030
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - esi = 0x05602890 edi = 0x05602900
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 43 firefox.exe!invoke_main() [exe_common.inl : 90]
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - Found by: inlining
[task 2023-09-19T06:04:28.568Z] 06:04:28 INFO - 44 firefox.exe!__scrt_common_main_seh() [exe_common.inl : 288 + 0x1b]
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - eip = 0x008a2409 esp = 0x051ffd30 ebp = 0x051ffd70 ebx = 0x04fc3000
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - esi = 0x05485030 edi = 0x05484710
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - 45 kernel32.dll!BaseThreadInitThunk + 0x18
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - eip = 0x754e7d49 esp = 0x051ffd78 ebp = 0x051ffd80 ebx = 0x04fc3000
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - esi = 0x05485030 edi = 0x05484710
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - 46 ntdll.dll!__RtlUserThreadStart + 0x2a
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - eip = 0x76efb74b esp = 0x051ffd88 ebp = 0x051ffdd8 ebx = 0x04fc3000
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - esi = 0x05485030 edi = 0x05484710
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - Found by: call frame info
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - 47 ntdll.dll!_RtlUserThreadStart + 0x1a
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - eip = 0x76efb6cf esp = 0x051ffde0 ebp = 0x051ffde8 ebx = 0x04fc3000
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - esi = 0x05485030 edi = 0x05484710
[task 2023-09-19T06:04:28.569Z] 06:04:28 INFO - Found by: call frame info
|
|
Assignee | |
Comment 3•1 year ago
|
||
So loading ole32.dll only on NS_FREE_PERMANENT_DATA would be enough? https://treeherder.mozilla.org/jobs?repo=try&revision=40176c27eb0db65b329374b2db47789551eb1eb9
This gets us back green on PGO and on tests for opt and debug
|
|
Assignee | |
Comment 4•1 year ago
|
||
|
|
Assignee | |
Comment 5•1 year ago
|
||
this was green on audio decoder tests as well as PGO build https://treeherder.mozilla.org/jobs?repo=try&revision=40176c27eb0db65b329374b2db47789551eb1eb9
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9e7852ce74f
Preload ole32.dll only on NS_FREE_PERMANENT_DATA r=bobowen
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
|
||
Updated•1 year ago
|
status-firefox117:
--- → wontfix
status-firefox118:
--- → affected
status-firefox-esr102:
--- → unaffected
status-firefox-esr115:
--- → unaffected
|
|
Assignee | |
Comment 8•1 year ago
|
||
Comment on attachment 9353926 [details]
Bug 1853627 - Preload ole32.dll only on NS_FREE_PERMANENT_DATA r?bobowen!
Beta/Release Uplift Approval Request
- User impact if declined: Failure to perform audio decoding for some format (e.g., AAC) on Windows
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Going back to the state we were prior 117 release, where we were not loading the ole32.dll lib except on debug builds
- String changes made/needed: N/A
- Is Android affected?: No
Attachment #9353926 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Updated•1 year ago
|
Blocks: utility-audiodecoder
|
||
Comment 9•1 year ago
|
||
Comment on attachment 9353926 [details]
Bug 1853627 - Preload ole32.dll only on NS_FREE_PERMANENT_DATA r?bobowen!
118 is on release now, potential ride-along if we have an RC2. We will otherwise include it in our planned dot release.
Attachment #9353926 -
Flags: approval-mozilla-beta? → approval-mozilla-release+
|
||
Comment 10•1 year ago
|
||
The patch landed in nightly and beta is affected.
:gerard-majax, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox118towontfix.
For more information, please visit BugBot documentation.
Flags: needinfo?(lissyx+mozillians)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(lissyx+mozillians)
|
|
||
Updated•1 year ago
|
Attachment #9353926 -
Flags: approval-mozilla-release+ → approval-mozilla-release?
|
|
Assignee | |
Comment 11•1 year ago
|
||
why was the approval reverted?
Flags: needinfo?(ryanvm)
Flags: needinfo?(pascalc)
|
|
||
Comment 12•1 year ago
|
||
It was an accidental approval. The intent was just to move the request from beta to release for later evaluation.
Flags: needinfo?(ryanvm)
Flags: needinfo?(pascalc)
|
|
Assignee | |
Comment 13•1 year ago
|
||
Nightly was showing a few flow of those errors (1-2 each ~3-5 days), until we shipped the fix there. Since there has been 0 report. I think we are safe
|
|
||
Comment 14•1 year ago
|
||
Comment on attachment 9353926 [details]
Bug 1853627 - Preload ole32.dll only on NS_FREE_PERMANENT_DATA r?bobowen!
Approved for our next 118 dot release, thanks.
Attachment #9353926 -
Flags: approval-mozilla-release? → approval-mozilla-release+
|
||
Comment 15•1 year ago
|
||
| uplift | ||
|
|
||
Comment 16•1 year ago
|
||
| bugherder uplift | ||
|
|
Assignee | |
Comment 17•1 year ago
|
||
With the 118 uplift arriving in users hand, I can see a downward trends on the amount of ERROR_INTERNAL_ERROR reported ; as of today, it was ~68% of erros on 117, similar value at first on 118 and now 118 is close to 45%
You need to log in
before you can comment on or make changes to this bug.
Description
•