1853701 - Enable :has on Nightly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

:has invalidation, for the most part, landed as part of bug 1792501.
Two open issues, but we think it can be enabled on Nightly for soak time.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1853701: Enable `:has` on Nightly. r=emilio,#layout-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a523925f8ff
Enable `:has` on Nightly. r=emilio

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in /css/css-conditional/at-supports-selector-detecting-invalid-in-logical-combinations.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/aa852933f7d9e619a7acbad1997a2ffbf8355d02

Push with failures

Failure log -> TEST-UNEXPECTED-PASS | /css/css-conditional/at-supports-selector-detecting-invalid-in-logical-combinations.html

Failure log -> TEST-UNEXPECTED-PASS | /dom/nodes/Element-closest.html | Element.closest with context node 'test4' and selector ':has(> :scope)' - expected FAIL

Comment 4

[David Shin[:dshin]]

Whoops - those weren't marked to set layout.css.has-selector.enabled. For now, I've made sure to set it in those tests.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd890d993c30
Enable `:has` on Nightly. r=emilio

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dd890d993c30

Comment 7

[Donal Meehan [:dmeehan]]

:dhsin could you please consider nominating this for release note? https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination
We could include it in nightly release notes

Comment 8

[David Shin[:dshin]]

Release Note Request
[Why is this notable]: This enables :has() selector by default on Nightly.
[Affects Firefox for Android]: Yes
[Suggested wording]: :has() selector allows authors to match elements that has (or "anchors") at least one element matching its relative selector.
[Links (documentation, blog post, etc)]: MDN

Two things of note:

• Invalidation of "inner selectors" is not yet supported. For example, given :has(:is(.a) .b), toggling .a on classes do not yet cause the selector map to be updated (Bug 1852965)
• Potential scaling issue with some :has() selectors & many insertions to DOM (bug 1853258)

Comment 9

[Donal Meehan [:dmeehan]]

Thanks, added to the nightly release notes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Nightly relnote superseded by bug 1858743.