1853920 - Launcher fails to properly quote empty command arguments

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Running firefox.exe --backgroundtask removeDirectory C:\Users\sasch\AppData\Local\Temp\firefox\xpcshellprofile "" "10", ".abc" somehow loses the argument "". Running this command opens two processes with different command line arguments in serial:

1. "C:\Users\sasch\Documents\GitHub\gecko-dev\obj-x86_64-pc-windows-msvc\dist\bin\firefox.exe" --backgroundtask removeDirectory C:\Users\sasch\AppData\Local\Temp\firefox\xpcshellprofile "" 100 .abc
2. C:\Users\sasch\Documents\GitHub\gecko-dev\obj-x86_64-pc-windows-msvc\dist\bin\firefox.exe --backgroundtask removeDirectory C:\Users\sasch\AppData\Local\Temp\firefox\xpcshellprofile 100 .abc (double spaces between the path and 100, somehow bugzilla ignores it)

This is not specific to background tasks, omitting --backgroundtask also does the same, although in that case the first process soon disappears and the one without the quote remains.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1853920 - [1/2] cleanup: merge function implementations r?#win-reviewers!

internal::ArgStrLen and internal::ArgToString must behave
identically. Merge them into a common implementation function to ensure
this.

Additionally, use size_t rather than int as an intermediate data
type where appropriate.

No functional changes.

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1853920 - [2/2] quote empty strings in Windows command lines r?#win-reviewers!

Quote empty arguments in command lines. Add appropriate tests.

Depends on D191127

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f07dd94abdef
[1/2] cleanup: merge function implementations  r=win-reviewers,mhowell
https://hg.mozilla.org/integration/autoland/rev/dda67fb9ec0f
[2/2] quote empty strings in Windows command lines  r=win-reviewers,gstoll

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f07dd94abdef
https://hg.mozilla.org/mozilla-central/rev/dda67fb9ec0f