Closed Bug 1853958 Opened 2 years ago Closed 2 years ago

Run the font-loader task eagerly for layout/base mochitests, to avoid intermittent failures during test_reftests_with_caret.html

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Similar to as-described in bug 1786170 comment 5: if the font loader task happens to complete while a test is running, it forces the top-level mochitest-harness document to reframe, and that forces its iframe (the thing hosting the mochitest) to temporarily think that it has lost focus (IsUnderHiddenEmbedderElement), until the next synthesized user interaction at least. And that's responsible for us sometimes getting snapshots that unexpectedly-lack-focus in that test.

This is the issue behind much of the intermittent failure volume on bug 1777050. On my windows system, this seems to be responsible for failures in bug923376.html at least (which is the most frequently failing test over there) -- I think that subtest is just unlucky enough to often overlap with the moment that the font loader completes.

Anyway: there's an easy workaround. We can just force the fonts to load eagerly by setting gfx.font_loader.delay to 0 for this directory (as we did for a different directory in bug 1786088). Let's do that.

Without this, the font-loader task is lazy and completes after some delay,
potentially while a test is running. When that happens, it triggers
frame-reconstruction during that test. That's particularly troublesome for
test_reftests_with_caret.html since it causes the nested iframe to render as if
it lacked focus, which is sufficient to cause many subtests there to fail.

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2de94de02c71 Run the font-loader task eagerly for layout/base mochitests. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: