Closed Bug 1853991 Opened 1 years ago Closed 1 year ago

Refactor SVGSVGElement intrinsic size APIs to return LengthPercentage

Categories

(Core :: SVG, task)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
firefox120 --- fixed

People

(Reporter: dlrobertson, Assigned: dlrobertson)

Details

Attachments

(1 file)

Bug 1853991 - Refactor SVGSVGElement intrinsic size APIs to return LengthPercentage. r=dholbert
48 bytes, text/x-phabricator-request
Details | Review

Instead of returning an integer from GetIntrinsicWidth and GetIntrinsicHeight, return a LengthPercentage. We currently return -1 when one of these functions is called on an SVG with the size attr set to a percentage value. After we have updated the return type, we can return LengthPercentage::Percentage for such cases.

  • Use LengthPercentage as the return type for GetIntrinsicHeight and
    GetIntrinsicWidth. This allows the caller to handle percent values.
  • Refactor intrinsic size function definitions.
Assignee: nobody → drobertson
Status: NEW → ASSIGNED
Pushed by drobertson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08cbb7e77d8f Refactor SVGSVGElement intrinsic size APIs to return LengthPercentage. r=dholbert

https://hg.mozilla.org/mozilla-central/rev/08cbb7e77d8f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox120: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: