Closed Bug 1854045 Opened 2 years ago Closed 2 years ago

Update regex to 1.9.4

Categories

(Core :: General, task)

task

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Keywords: perf-alert)

Attachments

(1 file)

No description provided.

The main side effect is the upgrade of aho-corasick to 1.1, which
contains a SIMD implementation for aarch64.

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(mh+mozilla)
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Well I wish I could land, but lando won't let me (bug 1855328)

Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/f1d6081744b0 Update regex to 1.9.4. r=emilio,supply-chain-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Regressions: 1860978
Regressions: 1861043
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Target Milestone: 120 Branch → ---

(In reply to Natalia Csoregi [:nataliaCs] from comment #6)

Backed out as requested for causing Bug 1860978 and Bug 1861043.

== Change summary for alert #40067 (as of Sat, 28 Oct 2023 16:32:28 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
53% perf_reftest recompute-position-vertical-lr.html linux1804-64-shippable-qr e10s fission stylo webrender-sw 0.93 -> 0.44

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40067

(In reply to Natalia Csoregi [:nataliaCs] from comment #6)

Backed out as requested for causing Bug 1860978 and Bug 1861043.

== Change summary for alert #40080 (as of Wed, 01 Nov 2023 09:49:13 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
2% Base Content Heap Unclassified windows11-64-2009-shippable-qr fission 1,761,637.67 -> 1,798,753.33
2% Base Content Heap Unclassified windows11-64-2009-shippable-qr fission 1,758,339.33 -> 1,795,335.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40080

The rust compiler has been updated twice since the first attempt, let's see how it goes this time.

Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/26b001cb3993 Update regex to 1.9.4. r=emilio,supply-chain-reviewers
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/79bf2d9de350 Update regex to 1.9.4. r=emilio,supply-chain-reviewers
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Regressions: 1866477

(In reply to Narcis Beleuzu [:NarcisB] from comment #12)

Backed out for build bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b9fe9a49496aa38ca77c335f20236610ef01a582
Log link: https://treeherder.mozilla.org/logviewer?job_id=436977892&repo=autoland&lineNumber=11302

== Change summary for alert #40328 (as of Tue, 21 Nov 2023 19:46:49 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
0.28% installer size osx-shippable nightly 88,364,962.69 -> 88,614,025.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40328

Flags: needinfo?(mh+mozilla)

(In reply to Cosmin Sabou [:CosminS] from comment #14)

https://hg.mozilla.org/mozilla-central/rev/79bf2d9de350

New baseline established from the regex update

== Change summary for alert #40547 (as of Mon, 04 Dec 2023 21:23:40 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
55% perf_reftest recompute-position-vertical-rl.html macosx1015-64-shippable-qr e10s fission stylo webrender 1.48 -> 0.66
29% perf_reftest recompute-position-vertical-rl.html macosx1015-64-shippable-qr e10s fission stylo webrender 2.00 -> 1.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40547

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: