1854196 - Modify categorization logic based on input from Data Science

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

Once data science agrees upon the logic for categorizing the page based on the domains, we’ll have to modify the existing categorization logic.

Comment 1

[James Teow [:jteow]]

In addition to the changes from Data Science, we should make the outputs consistent:

• This line should be referencing an integer value not a string output: https://searchfox.org/mozilla-central/rev/48b6992e03fa66f77ac9688ba61c95d31a451bc1/browser/components/search/SearchSERPTelemetry.sys.mjs#1482
• These should be parsed as an integer: https://searchfox.org/mozilla-central/rev/48b6992e03fa66f77ac9688ba61c95d31a451bc1/browser/components/search/SearchSERPTelemetry.sys.mjs#1493-1496, the reason why they are not is because Object property keys must be strings so the category numbers stored as a property key are converted to strings. We could cast the final category back to an integers.

Comment 2

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1854196 - Modify categorization logic based on input from Data Science. r?jteow

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2551e8d043d8
Modify categorization logic based on input from Data Science. r=jteow

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2551e8d043d8