1854257 - Opt-in card does not get dismissed upon opting in

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ania]

Attachment: sidebar

(macOS Monterey user).
Steps to reproduce

1. Opt-in, then opt-out from review checker (either via about config or settings).
2. Change browser.shopping.experience2023.optedIn state from 2 to 0.
3. Load a PDP, click the url bar icon.

Expected result

1. Opt-in card is displayed in the sidebar
2. Upon clicking "yes, try it" opt-in card is dissmissed and is replaced by one of the product analysis states.

Actual result

1. Opt-in card does not get dismissed after clicking “Yes, try it”, resulting in the attached sidebar states.
2. The situation persists on all subsequently opened PDP pages.

Comment 1

[Ania]

Attachment: Just in case attaching the snapshot of how my about:config prefs for shopping look like

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1854257 - Hide onboarding card for users opt-in after survey seen

Comment 3

[Pascal Chevrel:pascalc]

Ania, S1 severity is a release blocker ("S1: (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available"), is that really the case?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86fd71ad69b3
Hide onboarding card for users opt-in after survey seen r=omc-reviewers,shopping-reviewers,jprickett,kpatenio

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/86fd71ad69b3