1854271 - Add a price tag icon to the callouts 1 and 3

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ania]

Attachment: callout 1 - before&after.png

Let's please add a price tag icon to:

• callouts 1 - displayed to opted-in users upon closing sidebar for the first time,
• callout 3 - displayed to non-opted-in users upon closing the sidebar for the first time.

Figma

Comment 1

[Ania]

Attachment: callout 3 - before&after.png

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1854271 - Add price tag icons to Fakespot feature callouts. r=#omc-reviewers

Comment 3

[Shane Hughes [:aminomancer]]

Ania, is this worth uplifting? I think we had said it would be good to have whenever, so we marked it P2. But once this lands we could probably get it into 119 beta 2 or 3. Otherwise, it'll land in 120 (so won't be present for the beta experiment, but will be present for Nightly foxfooding).

Comment 4

[Ania]

In other circumstances, I'd say it's not essential to uplift, but I think in this case it would be good to have it for the 119 release experiment, as it should hopefully improve the aesthetics and recognizability of the feature (and we had foxfooding reports in which users had troubles finding the feature after they closed the sidebar and noticing the icon in the url bar).

Comment 5

[Shane Hughes [:aminomancer]]

[Tracking Requested - why for this release]: See comment 4

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f5bdce1e620
Add price tag icons to Fakespot feature callouts. r=omc-reviewers,negin

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f5bdce1e620

Comment 8

[Shane Hughes [:aminomancer]]

Comment on attachment 9354232 [details]
Bug 1854271 - Add price tag icons to Fakespot feature callouts. r=#omc-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: The 119 Release experiment for Fakespot will not have icons in the feature callouts. Initial foxfooding feedback indicated that the subject of the callouts wasn't as obvious as it could be. Adding icons is expected to make the connection between the callout and the review checker more intuitive.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature callouts already exist; this just places an icon in them, using an existing inline icon template that has previously been verified by QA.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 20230927034915.

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9354232 [details]
Bug 1854271 - Add price tag icons to Fakespot feature callouts. r=#omc-reviewers

Approved for 119.0b3

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/224612a72c7f

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 119.0b3 build.