1854401 - 0.27% installer size (OSX) regression on Fri September 15 2023

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push 80b1c6393b00d426ebf22109147720a1bbbf13b1. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.27%	installer size	osx-aarch64-shippable	aarch64 nightly	83,566,367.42 -> 83,790,256.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1792501

Comment 2

[David Shin[:dshin]]

~220 KiB increase, hrm.
This is a change essential for correct :has, which requires a different code path than the normal invalidation, so I'm not sure how much can be done.
I'll take a deeper look, though.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1792501

Comment 4

[Daniel Holbert [:dholbert]]

[triaging regressions affecting current beta]

Looks like the graph didn't move too much from bug 1854666, unfortunately. David, maybe you could look at this some more after you've finished your :has invalidation work?

Comment 5

[David Shin[:dshin]]

Yeah. bug 1854666 clawed back about 100 KiB.
bug 1855690 perhaps will help.