Closed
Bug 1854424
Opened 2 years ago
Closed 2 years ago
Add a LogicalMargin method returning an offset to start-sides
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
119 Branch
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file, 4 obsolete files)
We have use cases where we need an offest LogicalPoint formed from a LogicalMargin's IStart() and BStart(). Here are examples:
- https://searchfox.org/mozilla-central/rev/077fc34d03b85b09add26b5f99f1a3a3a72c8720/layout/forms/nsDateTimeControlFrame.cpp#138-140
- https://searchfox.org/mozilla-central/rev/077fc34d03b85b09add26b5f99f1a3a3a72c8720/layout/generic/nsFlexContainerFrame.cpp#5403-5404
I feel it would be convenient to have a LogicalMargin method such that we don't need to specify IStart() and BStart() separately.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9354383 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9354384 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9354385 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9354386 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9354382 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9354382 -
Attachment is obsolete: false
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/870b7352689d
Add a LogicalMargin method returning an offset to start-sides. r=layout-reviewers,jfkthame
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•