1854448 - [meta] Investigate elements that are failing Tier 2 a11y_checks for Desktop Firefox

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, the failing tests were failed-if by the bug 1854447.

This task is to track the investigation into the reasons each of these tests failed and to be able to backtrack these tests once they're resolved.

Individual bugs to block the following bugs

1. (all) this meta bug
2. (Interactive elements must be labeled / Node is enabled but disabled via the accessibility API) bug 1854227 (a11y_checks_labeled)
3. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Tests affected:

FAIL	toolkit/components/aboutconfig/test/browser/browser_clipboard.js	Node is not accessible via accessibility API		TH	
FAIL	toolkit/components/aboutconfig/test/browser/browser_clipboard.js	Node is not accessible via accessibility API		TD	cell-value
FAIL	toolkit/components/aboutconfig/test/browser/browser_clipboard.js	Node is not accessible via accessibility API	prefs	TABLE	
WARN	toolkit/components/aboutconfig/test/browser/browser_clipboard.js	Unlabeled element removed before l10n finished	show-all	BUTTON	ghost-button -
FAIL	toolkit/components/aboutconfig/test/browser/browser_edit.js	Node is not accessible via accessibility API		SPAN	
FAIL	toolkit/components/aboutconfig/test/browser/browser_edit.js	Node is not accessible via accessibility API		TD	cell-value
FAIL	toolkit/components/aboutconfig/test/browser/browser_edit.js	Node is not accessible via accessibility API		TH	
WARN	toolkit/components/aboutconfig/test/browser/browser_edit.js	Unlabeled element removed before l10n finished	show-all	BUTTON	ghost-button -
WARN	toolkit/components/aboutconfig/test/browser/browser_edit.js	Unlabeled element removed before l10n finished		INPUT	 -
WARN	toolkit/components/aboutconfig/test/browser/browser_edit.js	Unlabeled element removed before l10n finished		BUTTON	button-add semi-transparent -
WARN	toolkit/components/aboutconfig/test/browser/browser_edit.js	Unlabeled element removed before l10n finished		BUTTON	button-delete ghost-button semi-transparent -
WARN	toolkit/components/aboutconfig/test/browser/browser_edit.js	Unlabeled element removed before l10n finished		BUTTON	button-reset ghost-button semi-transparent -

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

Closing the meta bug since all the failing a11y-check instances were investigated and the only one bug 1882380 remains unresolved at the moment, but the patch to fix it has been approved and is ready to land.