18545 - [FLOAT] Problem Centering <TABLE> with <DIV> tag

Status: VERIFIED WORKSFORME

(Core :: Layout, defect, P3)

Description

[unapersson]

Applying align=center or text-align: center to a DIV tag does not center tables
within it. Using a <center> tag, which is a "shortcut" for <div align=center>,
however does work.

See testcase for examples

Comment 1

[unapersson]

Attachment: an example showing tables being centered by divs

Comment 2

[karnaze (gone)]

This is a block or line problem. Reassigning.

Comment 3

[leger]

Updating to default Layout Assignee...kipp no longer with us :-(

Comment 4

[troy]

Why are you re-reassing layout bugs? Do NOT touch layout bugs.

The bugs are assigned to Kipp so they can stay neatly organized until we have a
new owner for the block/inline code.

Comment 5

[buster]

mass moving all Kipp's pre-beta bugs to M15.  Nisheeth and I will
prioritize these and selectively move high-priority bugs into M13 and M14.

Comment 6

[buster]

mine! mine mine mine!  all mine!  whoo-hoo!

Comment 7

[buster]

Attachment: better test case

Comment 8

[buster]

the fix for this is to account for both NS_STYLE_TEXT_ALIGN_MOZ_CENTER and 
NS_STYLE_TEXT_ALIGN_CENTER in nsBlockReflowContext::AlignBlockHorizontally().  
Same for NS_STYLE_TEXT_ALIGN_MOZ_RIGHT, while I'm at it.

Comment 9

[rickg]

moving all buster m15 bugs to m16.

Comment 10

[buster]

fix checked in.  should be able to verify against 4/17/00 build.

Comment 11

[bsharma]

Verified.
Windows: 2000-07-13-09-M17

NOT fixed for Linux. Verified on 2000-07-13-08-M17 build.
The text and the cell are left justified for 2nd and 4th row.
But, they should be centered and right aligned respectively. 

Comment 12

[Hixie (not reading bugmail)]

Reopening per Bindu's last comments.

Comment 13

[buster]

extremely odd.  this is totally xp code.  I don't know why linux would behave
differently.  how does mac look?

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that I changed some of the behavior when fixing bugs 37083 and bug 40038
(so that 'text-align: center' doesn't center blocks, since there was no evidence
that real sites depended on that quirk).

Comment 15

[buster]

needs investigation.  won't make RTM, marking Future.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

On my Linux trunk build from a few days ago, all the testcases are correct as I
think they should be in both quirks and standard mode (HTML's align centers
blocks, CSS's text-align works according to the CSS spec).

Comment 17

[Hixie (not reading bugmail)]

Upon managerial request, adding the "testcase" keyword to 84 open layout bugs that
do not have the "testcase" keyword and yet have an attachement with the word
"test" in the description field. Apologies for any mistakes.

Comment 18

[Alexey Chernyak]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20001220
BuildID:    2000122004

text-align: when applied to block elements affects their inline content,
not the element itself, as per
http://www.w3.org/TR/REC-CSS2/text.html#propdef-text-align
<TABLE> is a block element NOT an inline element as defined in HTML:
http://www.w3.org/TR/html4/strict.dtd
http://www.w3.org/TR/html4/loose.dtd

I agree with David Baron. tables in 2nd and 4th rows *should* be left justified
To center the tables themselves { margin-left: auto; margin-right: auto; }
should be applied.

This bug seems to be fully resolved and works correctly for me.

Comment 19

[Robert Crews]

Attachment: A example of the bug showing context and a real-world use.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The auto margins go on the table itself, not the div containing the table.

Comment 21

[Robert Crews]

OK. Removing the DIV around the table and adding the definition 'TABLE {margin-
left: auto; margin-right: auto;}' to my style element causes part of the table 
to be centered: the caption is still off at the left of the page. The inline 
caption element is contained within the block table element. Is this a 
different bug?
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001228

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's not a bug.  CSS2 17.4.1 says:  "Captions above or below a 'table' element
are formatted very much as if they were a block element before or after the
table, except that (1) they inherit inheritable properties from the table, and
(2) they are not considered to be a block box for the purposes of any 'compact'
or 'run-in' element that may precede the table."  You'd need to add the same
auto margins to the caption.

Comment 23

[Robert Crews]

I understand. Thank you for your patience. I agree that this bug is resolved.

Comment 24

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 25

[Alexey Chernyak]

Can someone re-close this bug and mark it as FIXED?

Comment 26

[Hixie (not reading bugmail)]

Attachment: Same testcase, in standard mode

Comment 27

[Hixie (not reading bugmail)]

WORKSFORME on Win32 Netscape Commercial Build 2001030308.
WORKSFORME on Linux Netscape Commercial Build 2001030608.
(tested both quirks and standards mode)

Comment 28

[Alexey Chernyak]

vrfy