1854517 - Temporarily disable one Tier 2 a11y_checks for Ion

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing test while we continue investigation into the reasons this test failed and to be able to backtrack this test once they're resolved:

• A separate task to investigate the failed Tier 2 a11y_checks was filed in the bug 1849063.

Test affected:

FAIL	browser/components/ion/test/browser/browser_ion_ui.js	Node is not accessible via accessibility API	enrollment-button	BUTTON	primary

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the test failure is resolved and its associated bug is closed, remove the fail-if condition for a11y_checks from the appropriate file/section to ensure better test coverage and to avoid regressions in a11y of this component.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854517 - Temporarily fail-if one Tier 2 a11y_checks for Ion. r=rhelmer!,Jamie

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:

• Disabling tests: meta bug 1848402
• Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific bug 1849063
• Explore capturing click events for a11y_checks: bug 1692110

Depends on D188918

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec95287bd702
Temporarily disable one Tier 2 a11y_checks for Ion. r=rhelmer

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ec95287bd702

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out for causing multiple tier 2 failures on
Backout link
Push with failures

https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/973c41d2d0f0
Temporarily fail-if one Tier 2 a11y_checks for Ion. r=rhelmer

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/973c41d2d0f0