1854538 - Temporarily disable some Tier 2 a11y_checks for UI Widgets

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.

Tests affected:

Result	Path	Error	Element ID	Element tagName	Element className
FAIL	toolkit/content/tests/browser/browser_about_networking.js	Node is not accessible via accessibility API	category-dns	DIV	category category-no-icon
FAIL	toolkit/content/tests/browser/browser_autoscroll_disabled_on_editable_content.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_autoscroll_disabled_on_editable_content.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_autoscroll_disabled_on_links.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_autoscroll_disabled_on_links.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_cancel_starting_autoscrolling_requested_by_background_tab.js	Node is not accessible via accessibility API	tabbrowser-tabpanels	tabpanels	
FAIL	toolkit/content/tests/browser/browser_click_event_during_autoscrolling.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_click_event_during_autoscrolling.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_click_event_during_autoscrolling.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_click_event_during_autoscrolling.js	Node is not accessible via accessibility API		browser	
FAIL	toolkit/content/tests/browser/browser_label_textlink.js	Node is not focusable via the accessibility API	textlink-test	label	text-link
FAIL	toolkit/content/tests/browser/browser_label_textlink.js	Node is not focusable via the accessibility API	textlink-test	label	text-link
FAIL	toolkit/content/tests/browser/browser_label_textlink.js	Node is not focusable via the accessibility API	textlink-test	label	text-link
FAIL	toolkit/content/tests/browser/browser_starting_autoscroll_in_about_content.js	Node is not accessible via accessibility API		body	wide-container
FAIL	toolkit/content/tests/browser/datetime/browser_datetime_datepicker_min_max.js	Node is not accessible via accessibility API		td	
FAIL	toolkit/content/tests/browser/datetime/browser_datetime_datepicker_mousenav.js	Node is not accessible via accessibility API		td	weekend outside
FAIL	toolkit/content/tests/browser/datetime/browser_datetime_datepicker.js	Node is not accessible via accessibility API		td	outside
FAIL	toolkit/content/tests/browser/datetime/browser_datetime_toplevel.js	Node is not accessible via accessibility API		input	

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854538 - Temporarily fail-if some Tier 2 a11y_checks for UI Widgets. r=mconley,Jamie

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:

• Disabling tests: meta bug 1848402
• Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific meta bug 1854539
• Explore capturing click events for a11y_checks: bug 1692110

Depends on D188926

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/791f9b03ea96
Temporarily disable some Tier 2 a11y_checks for UI Widgets. r=mconley

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/791f9b03ea96

Comment 4

[Cristian Tuns]

Backed out for causing multiple tier 2 failures on a11y-checks.

• Backout link
• Push with failures

https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faba368d5da8
Temporarily fail-if some Tier 2 a11y_checks for UI Widgets. r=mconley

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/faba368d5da8