1854550 - Decouple PHC from replace_malloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, task, P1)

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 1. Fix a comment r=glandium

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 2. Move PHC into memory/build r=glandium

We want to link PHC directly alongside jemalloc so move its code into the
memory/build/ directory. This means that it's always statically linked even
when other replace_malloc libraries aren't.

The following patch will remove it from the replace_malloc configuration.

Depends on D188982

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 4. PHC doesn't use the malloc table to call jemalloc r=glandium

Depends on D188983

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 2. kAllocPoison should be static r=glandium

Depends on D188982

Comment 5

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 3. Define kAlloc{Junk,Poison} once for jemalloc and PHC r=glandium

Depends on D188983

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 5. Remove templating around allocation classes r=glandium

This will simplify references/linking between mozjemalloc and PHC. Plus
this code is clearer (more explicit) without it even though there's more
repitition.

Depends on D189241

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 6. Move AlignedAllocator into a header r=glandium

Move the AlignedAllocator class template into mozjemalloc.h where it can be
used by PHC also.

Depends on D190014

Comment 8

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 7. AlignedAllocator takes a class as an argument r=glandium

Depends on D190417

Comment 9

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 7. Move mPhcState out of the GMut class r=glandium

THis needs to move out so that the state can be accessed before gMut is
created.

Depends on D190419

Comment 10

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 8. Add a disabled state to PHCState r=glandium

We need to track if PHC failed to initialise. We can add a disabled state
to PHCState for that.

Depends on D190420

Comment 11

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 7. Call PHC directly rather than through replace malloc r=glandium

Depends on D190421

Comment 12

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 8. Rename a variable r=glandium

Depends on D190422

Comment 13

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 9. Move PHC interface from the bridge to PHC.h r=glandium

Comment 14

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 10. Allow LOG() with zero extra arguments r=glandium

This really only works-around the problem by adding an extra unused argument
to the macro.

Depends on D191133

Comment 15

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 11. PHC no-longer requires replace-malloc r=glandium

Depends on D191134

Comment 16

[Paul Bone [:pbone]]

Attachment: Bug 1854550 - pt 12. Allow inlining between mozjemalloc and PHC r=glandium

Depends on D191150

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e6e82ff6969
pt 1. Fix a comment r=glandium
https://hg.mozilla.org/integration/autoland/rev/498c79b32f88
pt 2. Move PHC into memory/build r=glandium
https://hg.mozilla.org/integration/autoland/rev/fa9f1571404e
pt 3. Define kAlloc{Junk,Poison} once for jemalloc and PHC r=glandium
https://hg.mozilla.org/integration/autoland/rev/587d6c02f925
pt 4. PHC doesn't use the malloc table to call jemalloc r=glandium
https://hg.mozilla.org/integration/autoland/rev/44c6b31c9fc0
pt 5. Remove templating around allocation classes r=glandium
https://hg.mozilla.org/integration/autoland/rev/f79fd63f0906
pt 6. Move AlignedAllocator into a header r=glandium
https://hg.mozilla.org/integration/autoland/rev/57c3eb49bb84
pt 7. Call PHC directly rather than through replace malloc r=glandium
https://hg.mozilla.org/integration/autoland/rev/e656c6464f14
pt 8. Rename a variable r=glandium
https://hg.mozilla.org/integration/autoland/rev/4418d8a41f12
pt 9. Move PHC interface from the bridge to PHC.h r=glandium
https://hg.mozilla.org/integration/autoland/rev/c3d700756320
pt 10. Allow LOG() with zero extra arguments r=glandium
https://hg.mozilla.org/integration/autoland/rev/34deef809a36
pt 11. PHC no-longer requires replace-malloc r=glandium
https://hg.mozilla.org/integration/autoland/rev/294e392145f1
pt 12. Allow inlining between mozjemalloc and PHC r=glandium

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9e6e82ff6969
https://hg.mozilla.org/mozilla-central/rev/498c79b32f88
https://hg.mozilla.org/mozilla-central/rev/fa9f1571404e
https://hg.mozilla.org/mozilla-central/rev/587d6c02f925
https://hg.mozilla.org/mozilla-central/rev/44c6b31c9fc0
https://hg.mozilla.org/mozilla-central/rev/f79fd63f0906
https://hg.mozilla.org/mozilla-central/rev/57c3eb49bb84
https://hg.mozilla.org/mozilla-central/rev/e656c6464f14
https://hg.mozilla.org/mozilla-central/rev/4418d8a41f12
https://hg.mozilla.org/mozilla-central/rev/c3d700756320
https://hg.mozilla.org/mozilla-central/rev/34deef809a36
https://hg.mozilla.org/mozilla-central/rev/294e392145f1