1854596 - Port over performance markers from playback to web codecs

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Description

[Paul Adenot (:padenot)]

So we can use the extension (https://github.com/padenot/fx-profiler-audio-cb) to assess web codecs's performance.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:padenot, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: WIP: Bug 1854596 - Add makers to WebCodecs Encoders

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Add worker to media profiler threads and alphabetize them

This patch introduces the "DOM Worker" thread into profiler's media
preset. Additionally, those thread names are alphabetized.

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Add makers to WebCodecs Encoders

Depends on D238713

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Add makers to WebCodecs Decoders

Depends on D238714

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Add ToString to EncodedVideoChunkData

Depends on D238879

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Add ToString to EncodedAudioChunkData

Depends on D238880

Comment 8

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Log info of decode request

Depends on D238881

Comment 9

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Remove unnecessary annotation

Depends on D238882

Comment 10

[C.M.Chang[:chunmin]]

Attachment: Bug 1854596 - Apply RAII-style markers in WebCodecs

This patch introduces a RAII-style profiler marker that automatically
starts tracking performance upon declaration and stops when
deconstructed. Additionally, it provides a manual stop method, giving
users full control over the tracking period.

Unlike passive timing based solely on the marker’s lifetime, this
approach allows developers to profile specific sections of code with
precision. This is particularly useful for accurately measuring
short-period execution, such as HW encoding or task dispatching, which
only take a few hundred or even just a few microseconds.

Depends on D239980

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46606d66ed1c
Add worker to media profiler threads and alphabetize them r=profiler-reviewers,julienw
https://hg.mozilla.org/integration/autoland/rev/deea9a263de6
Add makers to WebCodecs Encoders r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/38457654083f
Add makers to WebCodecs Decoders r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/8ba02172eee8
Add ToString to EncodedVideoChunkData r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c0a0231ce0af
Add ToString to EncodedAudioChunkData r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/377f2484a381
Log info of decode request r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9c0c76a7e749
Remove unnecessary annotation r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/ccce0bd331e0
Apply RAII-style markers in WebCodecs r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/db94f3c07e77
apply code formatting via Lando

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/46606d66ed1c
https://hg.mozilla.org/mozilla-central/rev/deea9a263de6
https://hg.mozilla.org/mozilla-central/rev/38457654083f
https://hg.mozilla.org/mozilla-central/rev/8ba02172eee8
https://hg.mozilla.org/mozilla-central/rev/c0a0231ce0af
https://hg.mozilla.org/mozilla-central/rev/377f2484a381
https://hg.mozilla.org/mozilla-central/rev/9c0c76a7e749
https://hg.mozilla.org/mozilla-central/rev/ccce0bd331e0
https://hg.mozilla.org/mozilla-central/rev/db94f3c07e77