1854650 - Out of line calls to VMWrapper functions don't have line number info

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

When running something like:

function GeneratePayloadTree(depth, tag) {
  if (depth == 0) {
    return {
      abray  : [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 ],
      spring : 
            'String for key ' 
            + 
            tag 
            + 
            ' in leaf node'
    };
  } else {
    return {
            left: 0,
            right: 1
    };
  }

}

var results = []
for (var i = 0; i < 50000; i++) {
    results.push(GeneratePayloadTree(i & 1, i));
}

with ac_add_options --enable-gc-probes all of the calls to VMWrapper: NewArrayObjectOptimzedFallback/ConcatStrings/Int32ToString get attributed to line 15 because that's the last line of debug info before the return of the function.

Instead the calls should get correct line number information.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Denis, any idea how easy this is to fix?

Comment 2

[Denis Palmeiro [:denispal]]

I'll take a look. Seems like the trackedsite for the NewPlainObject mir op is a JumpTarget js op at line 19.

Comment 3

[Iain Ireland [:iain]]

If this is all code generated by OutOfLineCallVM, you might be able to fix it by adding a perfspewer call here.

Comment 4

[Denis Palmeiro [:denispal]]

Attachment: Bug 1854650: Annotate out of line calls in perfspewer. r=iain!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e967b12928a
Annotate out of line calls in perfspewer. r=iain

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0e967b12928a