1854701 - ./mach addtest doesn't add new tests to browser.toml files

Status: RESOLVED FIXED

(Testing :: General, defect, P2)

Description

[Erik Nordin [:nordzilla]]

It seems that Bug 1853243 moved migrated several browser.ini files to now be browser.toml files.

./mach addtest does not seem to be aware of adding the new test to the browser.toml file, where as it used to add it automatically in the correct alphabetic location to the browser.ini file.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jmaher, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[:Gijs (he/him)]

We actively encourage people to use addtest rather than changing manifests and/or writing test boilerplate by hand (because humans are forgetful and sorting files by hand is a bad use of time), and it being broken for a month I'd argue is significantly worse than S4. Can we get this fix prioritized?

(I'll take a pointer to what needs fixing if there isn't bandwidth from the people working on this; https://searchfox.org/mozilla-central/rev/10d0e01455559a433670bd718a3ecc0ece5d2cb9/testing/mach_commands.py#173 is the implementation and off-hand I don't see something obvious - but it's also not 100% clear from comment 0 what exactly is broken ie what kind of error message or brokenness happens)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

it is P2, i.e. once we get a bit further with the migration we were going to fix this up. This should be fairly straightforward to fix, we just need a day with nothing else breaking to look at it.

:tmarble- could you get this on your plate once batch 10 and 19 are done?

Comment 4

[Greg Tatum [:gregtatum]]

Example failure output:

➤ ./mach addtest browser/components/translations/tests/browser/browser_translations_panel_engine_destroy2.js
Adding a test file at browser/components/translations/tests/browser/browser_translations_panel_engine_destroy2.js (suite `mochitest-browser-chrome`)
Could not open manifest file browser/components/translations/tests/browser/browser.ini
Please make sure to add the new test to your commit. You can now run the test with:
    ./mach mochitest browser/components/translations/tests/browser/browser_translations_panel_engine_destroy2.js

Comment 5

[Tom Marble]

:jmaher yes I'll look into this

Comment 6

[:Gijs (he/him)]

Thanks to Erik for the failure message, I think I have a working patch. :-)

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1854701 - fix mach addtest so it can cope with toml manifests, r?tmarble,jmaher

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2ee2618643c
fix mach addtest so it can cope with toml manifests, r=jmaher

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e2ee2618643c