1854878 - Crash in [@ opensl_configure_playback]

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/c26781bc-19b7-4e0a-97b2-9791b0230925

This is not a new crash signature, but it looks like there was a small increase in these Android crashes in 118.

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libxul.so  opensl_configure_playback  media/libcubeb/src/cubeb_opensl.cpp:1327
0  libxul.so  opensl_stream_init  media/libcubeb/src/cubeb_opensl.cpp:1576
1  libxul.so  cubeb_stream_init  media/libcubeb/src/cubeb.c:377
2  libxul.so  mozilla::CubebUtils::CubebStreamInit  dom/media/CubebUtils.cpp:382
3  libxul.so  mozilla::AudioStream::OpenCubeb  dom/media/AudioStream.cpp:274
3  libxul.so  mozilla::AudioStream::Init  dom/media/AudioStream.cpp:257
4  libxul.so  mozilla::AudioSink::InitializeAudioStream  dom/media/mediasink/AudioSink.cpp:129
5  libxul.so  mozilla::AudioSinkWrapper::SyncCreateAudioSink  dom/media/mediasink/AudioSinkWrapper.cpp:480
6  libxul.so  mozilla::VideoSink::Start  dom/media/mediasink/VideoSink.cpp:233
7  libxul.so  mozilla::MediaDecoderStateMachine::StartMediaSink  dom/media/MediaDecoderStateMachine.cpp:4134

Comment 1

[Paul Adenot (:padenot)]

https://github.com/mozilla/cubeb/pull/760

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1854878 - Update libcubeb to revision f1bfefbbd. r?#cubeb-reviewers

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1854878 - Reapply patch on top of libcubeb. r?#cubeb-reviewers

Depends on D189196

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf6ece77d377
Update libcubeb to revision f1bfefbbd. r=cubeb-reviewers,kinetik
https://hg.mozilla.org/integration/autoland/rev/fb0bab9dfaad
Reapply patch on top of libcubeb. r=cubeb-reviewers,kinetik

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 9355019 [details]
Bug 1854878 - Update libcubeb to revision f1bfefbbd. r?#cubeb-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Crash on Android in some cases that I think are quite rare but possible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a trivial fix, android only.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit BugBot documentation.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bf6ece77d377
https://hg.mozilla.org/mozilla-central/rev/fb0bab9dfaad

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9355019 [details]
Bug 1854878 - Update libcubeb to revision f1bfefbbd. r?#cubeb-reviewers

Approved for 119.0b3

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6575dfb54635
https://hg.mozilla.org/releases/mozilla-beta/rev/9d3910060c03

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9355019 [details]
Bug 1854878 - Update libcubeb to revision f1bfefbbd. r?#cubeb-reviewers

Approved for our next 118 dot release, thanks.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9355020 [details]
Bug 1854878 - Reapply patch on top of libcubeb. r?#cubeb-reviewers

Approved for our next 118 dot release, thanks.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/4c34f6b9a10c
https://hg.mozilla.org/releases/mozilla-release/rev/64faf60bdfb3

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/4c34f6b9a10c
https://hg.mozilla.org/releases/mozilla-release/rev/64faf60bdfb3