Don't run cookie banner handling if the domain was opened within the browsing session
Categories
(Core :: Privacy: Anti-Tracking, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox121 | --- | fixed |
People
(Reporter: timhuang, Assigned: timhuang)
References
Details
Attachments
(4 files)
The cost of running cookie banner handling could be expensive, and we don't need to run the code if the code has ever been executed for a domain because either the banner was handled or we don't support the domain. So, we can add a cooldown mechanism to stop running cookie banner handling in such cases to save the cost.
However, not running Cookie Banner Handling could risk not handling the banner if the cookie banner state was changed for certain reasons. Therefore, the cooldown mechanism should only stop running the code within the same browsing session.
Comment 1•1 year ago
|
||
This needs to reset if site data is cleared or if the user re-enabled cookie banner handling per site.
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
To improve the overall performance of cookie banner clicking mechanism. This
patch makes the cookie banner clicking mechanism only executes once per
browsing session.
Assignee | ||
Comment 3•1 year ago
|
||
The patch add a CookieBannerCleaner to ClearDataService. The clearner
clears the cookie banner exception and handledRecord.
Depends on D190763
Assignee | ||
Comment 4•1 year ago
|
||
Depends on D190764
Assignee | ||
Comment 5•1 year ago
|
||
Depends on D190765
Comment 7•1 year ago
|
||
Backed out for causing multiple failures.
-
Failure line: TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_forget_about_site_security_headers.js | xpcshell return code: 0
- Push with failures - another xpcshell failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/cleardata/tests/unit/test_basic.js | xpcshell return code: 0
- Push with failures - mochitests failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/cookiebanners/test/browser/browser_cookiebanner_webconsole.js | Test timed out -
Assignee | ||
Updated•1 year ago
|
Comment 9•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e5cfc4f4dc77
https://hg.mozilla.org/mozilla-central/rev/9b94b2e2033c
https://hg.mozilla.org/mozilla-central/rev/3d28d021a30b
https://hg.mozilla.org/mozilla-central/rev/5392006086fa
Description
•