1855025 - Implement "browser.getClientWindows" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

The WebDriver BiDi spec is not done yet. As such we cannot implement it for M9. Lets push onto the backlog for now.

Comment 2

[Dan]

@whimboo following the link you provided. It appears this issue is now completed, and the specification for browser.ClientWindows is ready. I will take a stab at it.

Comment 3

[Dan]

Okay, I am looking to work on this issue of implementing browser.getClientWindows for Webdriver Bidi (https://bugzilla.mozilla.org/show_bug.cgi?id=1855025).

From the W3C specification, implementing this command requires access to window state. Now, from checking the code base, I discovered that while WindowState is available under Marionette, it is not available in the remote/shared. The WindowState implementation is contained in the browser module (https://searchfox.org/mozilla-central/source/remote/marionette/browser.sys.mjs) under Marionette.

I would think implementing this command would require moving the browser module in Marionette to the shared directory. Is that right?

Comment 4

[Julian Descottes [:jdescottes]]

As mentioned on Matrix, the WindowState object is a very simple helper to translate from https://searchfox.org/mozilla-central/rev/b784b4ed27d0fc41a9bbce7d666e1cfcac4778be/dom/webidl/Window.webidl#592

readonly attribute unsigned short windowState;

to a string.

WebDriver and WebDriver BiDi happen to use the same strings for the window state, so I think it's fine to move just this helper to remote/shared and then use it from both Marionette and BiDi?

Comment 5

[Dan]

(In reply to Julian Descottes [:jdescottes] from comment #4)

As mentioned on Matrix, the WindowState object is a very simple helper to translate from https://searchfox.org/mozilla-central/rev/b784b4ed27d0fc41a9bbce7d666e1cfcac4778be/dom/webidl/Window.webidl#592

readonly attribute unsigned short windowState;

to a string.

WebDriver and WebDriver BiDi happen to use the same strings for the window state, so I think it's fine to move just this helper to remote/shared and then use it from both Marionette and BiDi?

Yes, absolutely. I will move it.

Comment 6

[Dan]

Attachment: Bug 1855025 - [webdriver-bidi] Implement "browser.getClientWindows" command.

Comment 7

[Dan]

Attachment: Bug 1855025 - [wdspec] Implement "browser.getClientWindows" command tests.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Hello Dan. I wanted to check back with you if you may have the time to apply the remaining review comments to the patch? It would be great to get this new feature landed. Thanks a lot.

Comment 9

[Dan]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #8)

Hello Dan. I wanted to check back with you if you may have the time to apply the remaining review comments to the patch? It would be great to get this new feature landed. Thanks a lot.

I just did. I didn't mark the comments as done.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb59e0c8fc9
[webdriver-bidi] Implement "browser.getClientWindows" command. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/346312f12562
[wdspec] Implement "browser.getClientWindows" command tests. r=whimboo,webdriver-reviewers

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48980 for changes under testing/web-platform/tests

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/abb59e0c8fc9
https://hg.mozilla.org/mozilla-central/rev/346312f12562

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot