1855174 - Process node server output in realtime

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

console.log messages from the node servers would benefit from being displayed in the logs at the time they are issues, not at the end of the test.
To achieve this, we need to be reading from the stdout,stderr streams on a separate thread and push it out into self.log.info

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1855174 - Process xpcshell node output in realtime r=jmaher

Spawned nodejs servers sometimes print output to stdout or stderr.
While it's not strictly necessary to display, it's sometimes useful for
debugging, but it's problematic that we only dump the output when killing
the node server.

After landing D189212 this becomes even more problematic, as killing the
process via os.killpg means the file descriptors are already closed.

This patch makes it so for each started server we also spawn a new thread
that reads from stdout and stderr. This way the output is present in the
logs at the correct time.

Depends on D189212

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45571d960e8a
Process xpcshell node output in realtime r=jmaher,necko-reviewers,kershaw

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1772329 for causing xpcshell failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/a1364ddc431a922f132fc31eb6f3caecf0bde3f0
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=45571d960e8a9df0e42fd383075781b2a90b6e07
• failure log: https://treeherder.mozilla.org/logviewer?job_id=430610324&repo=autoland

[task 2023-09-28T08:08:47.458Z] cleanup
[task 2023-09-28T08:08:47.492Z] ++ cleanup
[task 2023-09-28T08:08:47.493Z] ++ local rv=0
[task 2023-09-28T08:08:47.496Z] ++ [[ -s /builds/worker/.xsession-errors ]]
[task 2023-09-28T08:08:47.497Z] ++ cp /builds/worker/.xsession-errors /builds/worker/artifacts/public/xsession-errors.log
[task 2023-09-28T08:08:47.501Z] /builds/worker/bin/test-linux.sh: line 97:   120 Terminated              ${mozharness_bin}
[task 2023-09-28T08:08:47.503Z] ++ '[' ']'
[task 2023-09-28T08:08:47.504Z] ++ true
[task 2023-09-28T08:08:47.504Z] ++ cleanup_xvfb
[task 2023-09-28T08:08:47.506Z] +++ pidof Xvfb
[task 2023-09-28T08:08:47.507Z] ++ local xvfb_pid=49
[task 2023-09-28T08:08:47.508Z] ++ local vnc=false
[task 2023-09-28T08:08:47.516Z] ++ local interactive=false
[task 2023-09-28T08:08:47.517Z] ++ '[' -n 49 ']'
[task 2023-09-28T08:08:47.518Z] ++ [[ false == false ]]
[task 2023-09-28T08:08:47.518Z] ++ [[ false == false ]]
[task 2023-09-28T08:08:47.519Z] ++ kill 49
[task 2023-09-28T08:08:47.520Z] ++ screen -XS xvfb quit
[task 2023-09-28T08:08:47.521Z] No screen session found.
[task 2023-09-28T08:08:47.522Z] ++ true
[task 2023-09-28T08:08:47.523Z] ++ exit 0
[taskcluster 2023-09-28 08:08:48.559Z] === Task Finished ===
[taskcluster 2023-09-28 08:08:49.206Z] Unsuccessful task run with exit code: 241 completed in 253.091 seconds

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5517b78726
Process xpcshell node output in realtime r=jmaher,necko-reviewers,kershaw

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ee5517b78726