1855218 - Regression: "Show all the bookmarks folders" button resets changes to Location dropdown in bookmarking pane

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Stephan Sokolow]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Click the bookmarking star
2. Select a folder from the Location drop-down
3. Click the Show all bookmarks folders arrow

Actual results:

Step 3 undoes step 2, resetting the Location dropdown to what it started as, requiring me to consciously open the "Show all..." tree before I select a recently-used folder to jump the tree's scroll position near to my desired folder.

(Yeah, this workflow is a hack to make up for the lack of an as-you-type filtering field in the bookmarking pane.)

Expected results:

Up until a few versions ago (Yeah, it was a huge demotivating factor that, despite WebExtensions not exposing an API to meddle there AFAIK, I anticipated being asked to test with extensions disabled), Firefox didn't care whether I showed the tree widget before or after I selected the Location.

If I wanted, to, for example, select "Videos to Watch > SciShow" and then scroll to "Videos to Watch > Simon Whistler > Megaprojects", I could do that without first having to open the dropdown.

(This is literally the use-case. Dumping giant numbers of "you might also like..." results on sites like YouTube and Medium into categorized TODO bookmarks to circumvent the "watch now or watch never" dilemma with a "In all honesty, probably watch never, but I can still believe I'll come back to these" option.)

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f259e02b50c5815861cbdb6237974936c5cdc36d&tochange=ef8f6537c34677c54436474d87b233bdc707de55

Comment 2

[Marco Bonardo [:mak]]

Thanks Alice0775.

The folder is not changed immediately on the bookmark anymore as it was before, it's likely when the open the folder picker we check the original bookmark folder instead of the currently selected one.
This is easily reproducible so it should be actionable.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812083

:jsudiaman, since you are the author of the regressor, bug 1812083, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Jonathan Sudiaman [:jsudiaman]]

(In reply to Marco Bonardo [:mak] from comment #2)

Thanks Alice0775.

The folder is not changed immediately on the bookmark anymore as it was before, it's likely when the open the folder picker we check the original bookmark folder instead of the currently selected one.
This is easily reproducible so it should be actionable.

In editBookmark.js, need to update this._paneInfo.parentGuid before the call to this._folderTree.selectItems().

Comment 5

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1855218 - Regression: "Show all the bookmarks folders" button resets changes to Location dropdown in bookmarking pane r?mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/489e7952cd67
Regression: "Show all the bookmarks folders" button resets changes to Location dropdown in bookmarking pane r=mak,places-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/489e7952cd67

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jsudiaman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Jonathan Sudiaman [:jsudiaman]]

Simple workaround exists, i.e. expanding the folder tree before choosing a drop-down option, so my vote is wontfix for Fx 119.