1855307 - Add some improvements to slot and shadow DOM mutation handling for Firefox Translation

Status: RESOLVED FIXED

(Firefox :: Translations, defect, P2)

Comment 1

[amie]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

open https://forums.archlinux.fr/viewtopic.php?p=176719#p176719
translate it from French to English
Actual results:
https://dr-baghaei.com/
The code in code blocks disappears (except the last block).

Expected results:

Code remains there.

Comment 2

[Sean Feng [:sefeng]]

Attachment: Bug 1855307 - Fix a bug in Firefox Translation where slotted text node is not translated r=gregtatum

Comment 3

[Sean Feng [:sefeng]]

Attachment: Bug 1855307 - Add basic ShadowDOM mutation supports to Firefox Translation r=gregtatum

Depends on D189390

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ac5799adfe7
Fix a bug in Firefox Translation where slotted text node is not translated r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/82d05c33e866
Add basic ShadowDOM mutation supports to Firefox Translation r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/05517f617531
apply code formatting via Lando

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0ac5799adfe7
https://hg.mozilla.org/mozilla-central/rev/82d05c33e866
https://hg.mozilla.org/mozilla-central/rev/05517f617531

Comment 6

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

:sefeng, anything here worth mentioning in the fx120 release notes?

Comment 7

[Greg Tatum [:gregtatum] (not responding to NI until Jun 17)]

No, this is a quality fix where parts of the page were not translated.

Comment 8

[Sean Feng [:sefeng]]

Comment on attachment 9355358 [details]
Bug 1855307 - Fix a bug in Firefox Translation where slotted text node is not translated r=gregtatum

Beta/Release Uplift Approval Request

• User impact if declined: Some content in shadow dom may not be translated
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1841656
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is trivial and is covered by automated tests
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Sean Feng [:sefeng]]

Comment on attachment 9355359 [details]
Bug 1855307 - Add basic ShadowDOM mutation supports to Firefox Translation r=gregtatum

Beta/Release Uplift Approval Request

• User impact if declined: Some content in shadow dom may not be translated
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1841656
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is trivial and is covered by automated tests
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9355358 [details]
Bug 1855307 - Fix a bug in Firefox Translation where slotted text node is not translated r=gregtatum

Approved for 119.0b5

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e38c3df6918
https://hg.mozilla.org/releases/mozilla-beta/rev/e50b4a6e9542
https://hg.mozilla.org/releases/mozilla-beta/rev/886ea43c2de1

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9355359 [details]
Bug 1855307 - Add basic ShadowDOM mutation supports to Firefox Translation r=gregtatum

Approved for our next 118 dot release, thanks.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/4f7fbbc56de6
https://hg.mozilla.org/releases/mozilla-release/rev/3063a1cbafc5
https://hg.mozilla.org/releases/mozilla-release/rev/04ea3295f950

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/4f7fbbc56de6
https://hg.mozilla.org/releases/mozilla-release/rev/3063a1cbafc5
https://hg.mozilla.org/releases/mozilla-release/rev/04ea3295f950