Closed Bug 1855312 Opened 2 years ago Closed 2 years ago

Mach telemetry is not being reported

Categories

(Firefox Build System :: Mach Core, defect, P3)

defect

Tracking

(firefox-esr115 unaffected, firefox118 wontfix, firefox119 wontfix, firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox118 --- wontfix
firefox119 --- wontfix
firefox120 --- fixed

People

(Reporter: ahochheiden, Assigned: ahochheiden)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The issue is with https://searchfox.org/mozilla-central/source/python/mach/mach/telemetry.py#39 and the changes in Bug 1695312. At this point in the code, the mach virtualenv is only active for the clobber command. As such, NoopTelemetry is instantiated for all other commands, resulting in no telemetry being reported.

Changes in Bug 1695312 made it so the actual command site is activated
much sooner, as such, at this point in the program execution, any of the
'Mach' sites can be active, so we should check against all of them.

In the past, the 'mach' site was the only one that could be active at
this time, so it was the only one that was needed to be checked for.

Set release status flags based on info from the regressing bug 1695312

Pushed by ahochheiden@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72153d629a08 Check against all possible 'Mach' sites when activating telemetry, rather than just the `mach` site r=sheehan
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

The patch landed in nightly and beta is affected.
:ahochheiden, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(ahochheiden)
Regressions: 1855716
Flags: needinfo?(ahochheiden)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: