Closed Bug 1855314 Opened 2 years ago Closed 2 years ago

Translation feature advertised in popup in spite of UserMessaging policy

Categories

(Firefox :: Translations, enhancement)

Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox-esr115 --- disabled
firefox118 --- disabled
firefox119 --- disabled
firefox120 --- disabled
firefox123 --- fixed

People

(Reporter: edelbitter, Assigned: mkaply)

Details

Attachments

(3 files)

Steps to reproduce:

Policy with UserMessaging.*=false applied
Open Firefox after upgrading from 117.0.1 to 118.0

Actual results:

Popup titled "Try private translations in Firefox BETA" extending from URLbar into restored tab, requires input device to recover.

Expected results:

No ads/interventions/recommendations whatsoever, unobstructed UI & web content.

Component: Untriaged → Enterprise Policies
Hardware: Unspecified → Desktop

I will confirm this report as an enhancement considering that this modal was originally implemented to pop up when a page is written in a different language than your browser. I cannot say whether this is valid or not. More knowledgeable people will be involved.

Thank you for your contribution!

Status: UNCONFIRMED → NEW
Type: defect → enhancement
Component: Enterprise Policies → Translation
Ever confirmed: true
OS: Unspecified → All
Version: Firefox 118 → Trunk

What's the intent for UserMessaging? The translations popup is a feature, and not an advertisement of a feature. The first time it shows, we have an onboarding message explaining how to use it, which makes it feel more like an advertisement of a feature. However, this messaging is only on the first time it is shown, after that it's just a modal.

To disable the automatic popup behavior set the following to false: "browser.translations.automaticallyPopup"
To disable the first run messaging set to true: "browser.translations.panelShown"

I would ask :mkaply, but his needinfo is disabled today.

The reporter's assumption here is: "unobstructed UI & web content", but an "alert()" in a webpage is not disabled as far as I can tell, which is more analogous to what is going on here. There isn't a lot of documentation that I can find at least on the policy itself.

If there is any ambiguity between
a) things Firefox allows -websites- to do, including alert(), and
b) policy asking the -Firefox- to not recommend a feature,
imagine the following test case:

  1. set "Prevent Firefox from messaging the user in certain situations" policies
    https://github.com/mozilla/policy-templates/tree/master#usermessaging
  2. launch firefox.exe 'https://magenta.test'
    magenta.test = <html lang="fr-FR"><style>*{background:#f0f}</style></html>
    sucess = Firefox is showing mostly magenta pixels
    failure = Firefox is recommending the user try some feature/offer/extension/..
    possible test variation matrix: always translate on, --kiosk, reader mode, tiny screen, ..

A popup that says "Try private translations in Firefox " feels like recommending a feature so disabling it with the feature recommendations policy seems reasonable.

Can someone show the popup?

After the first time the user sees the popup, the text will just read "Translate this page".
We could show the second version of the popup since the beginning when this policy is enabled.

Thinking about this more, I think we should set browser.translations.panelShown with the policy, but if an administrator wants to remove the popup completely, they'll need to set the preference via policy.

This is a useful feature.

When I document the new behavior, I'll mention the other pref.

Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/e20257bfa3ef Don't show translations first run if FeatureRecommendations policy is false. r=gregtatum
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: