1855353 - Text on the Bookmarks Toolbar is lighter and New Tab button is darker when System theme is enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[6k64x4ma]

Attachment: System theme

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

1. Select the light mode in Windows.
2. Select the System theme in Firefox.
3. Make the Bookmarks Toolbar visible.

Actual results:

• Text on the Bookmarks Toolbar is lighter and New Tab button is darker than in Firefox 118.
• When the Light theme is enabled in Firefox, these colors are the same as before.

Expected results:

• These colors should match the Light theme.

Comment 1

[6k64x4ma]

Attachment: Light theme

Comment 2

[6k64x4ma]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=751ce10ffa95f4706e709666d45db519e48786c7&tochange=85ed967e285f304f7709461aec0d33ca72805791

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1843044, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855353 - Make system theme colors match light theme more closely. r=dao

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1843044

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc441449616e
Make system theme colors match light theme more closely. r=dao,desktop-theme-reviewers

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dc441449616e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9355276 [details]
Bug 1855353 - Make system theme colors match light theme more closely. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9355276 [details]
Bug 1855353 - Make system theme colors match light theme more closely. r=dao

Approved for 119.0b3

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c756afd8c9b

Comment 12

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Nightly 120.0a1 (build id: 20230926092749) using Windows 10.
Verified - Fixed in the latest Nightly 120.0a1 (build id: 20230928215127) and Beta 119.0b3 (verified with treeherder build: 1a41a118193d), on Windows 10.