1855376 - AWSY reports memory increase with parallel marking enabled

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P5)

Description

[Jon Coppeard (:jonco)]

AWSY shows a high confidence increase of 2% in Base Content JS opt fission:

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=0ee951c528cdfadaa7ccfcdf4b07e56f1e439e1f&newProject=try&newRevision=853190f90b330b5020a05bea6df16b4747ffc890&framework=4&page=1

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1855376 - Free stacks of extra parallel markers between GCs r?sfink

We currently keep all mark stacks allocated after GC, shrunk to their default size.

For parallel marking we can free the mark stacks of all markers apart from the
first. If we fail to allocate them at the start of marking we can fall back to
not marking in parallel.

This fixes the AWSY regression.

The patch also changes GCMarker::reset() to cover everything that happens in
GCMarker::stop() so you don't need to call both.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a48628bd293
Free stacks of extra parallel markers between GCs r=sfink

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3a48628bd293