Closed
Bug 1855390
Opened 2 years ago
Closed 2 years ago
Remove nsNavBookmarks::GetItemTitle() call from nsNavHistory::RowToResult()
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: mak, Assigned: daisuke)
References
Details
(Whiteboard: [sng][places-performance])
Attachments
(1 file)
I don't see a reason for it today, I suspect historically we could end up with shortcuts having no bookmark title, but if I search my database all the place: shortcuts have a title today, plus QUERY_TYPE_BOOKMARKS seems to just always select the bookmark title.
This is likely a pointless query we run.
|
Reporter | |
Updated•2 years ago
|
Whiteboard: [sng][places-performance]
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a0bbb6d1f6a
Stop calling nsNavBookmarks::GetItemTitle() from nsNavHistory::RowToResult() r=places-reviewers,mak
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•