[wpt-sync] Sync PR 42119 - Treat unrun tests as critical errors in TestRunnerManager.run
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox120 fixed)
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Depends on 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 42119 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/42119
Details from upstream follow.
Sam Sneddon <gsnedders@apple.com> wrote:
Treat unrun tests as critical errors in TestRunnerManager.run
Following an uncaught exception in TestRunnerManager.run we will never recreate the TestRunnerManager (as we assume it has successfully contained all the errors raised elsewhere, either via restarting the TestRunner or within itself), thus we should treat any uncaught exception as a critical error.
Additionally, always treat any unrun tests as a critical error, regardless of whether we exited the loop cleanly or not. We should always have exhausted the queue as otherwise we'll end up with a partial test run, and the user will have no way to know that we didn't run everything requested.
This practically fixes #41386 as we'll now exit uncleanly and not end up with a partial run, but we may want to add further critical errors on the path that led to that.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•