Closed Bug 1855484 Opened 2 months ago Closed 2 months ago

When reloading and breaking on pretty printed source, the bundle shouldn't be opened

Categories

(DevTools :: Debugger, enhancement)

enhancement

Tracking

(firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Following bug 1843454 STR, you can see that we "briefly" open the bundle/non-pretty-printed source on reload.
This causes lots of very slow computations whereas we should focus on pretty printing the bundle and open it ASAP.

We were selecting the bundle/generated source, which cause lots of heavy computation
whereas we meant to display the pretty printed source right after.

Also, we have to be careful to only proceed with pretty printed location selection
only once the frames are mapped. Otherwise selectLocation would query setInScopeLines against
the generated frames and be wrong as well as spawn lots of useless computations!

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8efc421b915
[devtools] Avoid selecting the bundle/generated source when reloading and pausing on a pretty printed source. r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch

== Change summary for alert #39901 (as of Wed, 11 Oct 2023 06:38:00 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
13% damp custom.netmonitor.reload.DAMP windows10-64-shippable-qr e10s fission stylo webrender 358.53 -> 404.43
6% damp custom.jsdebugger.close.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 26.34 -> 28.00
4% damp custom.netmonitor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 268.66 -> 280.14

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
59% damp custom.pretty-print.jsdebugger.reload.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 27,861.59 -> 11,514.80
58% damp custom.pretty-print.jsdebugger.reload.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 27,210.82 -> 11,321.91
58% damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 28,103.37 -> 11,840.77
58% damp custom.jsdebugger.pretty-print.reload-and-pause.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 27,447.86 -> 11,639.91
57% damp custom.pretty-print.jsdebugger.reload.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 19,228.60 -> 8,278.79
... ... ... ... ...
2% damp custom.jsdebugger.project-search.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 2,176.14 -> 2,127.81

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39901

You need to log in before you can comment on or make changes to this bug.