1855531 - Add InstrumentedProps for DOM core interface members

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Attachment: Bug 1855531 - Part 1: Move InstrumentProps from HTMLDocument to Document r=#webidl

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until Dec 11)]

Attachment: Bug 1855531 - Part 2: Add InstrumentedProps for DOM core interfaces r=#webidl

This covers things supported by WebKit and Blink but not in Gecko, and then manually picked for easier review. Mostly automated by https://github.com/saschanaz/gecko-webidl-frustrated.

Depends on D189411

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f1de5ca0812
Part 1: Move InstrumentProps from HTMLDocument to Document r=webidl,emilio
https://hg.mozilla.org/integration/autoland/rev/da5ea190fef6
Part 2: Add InstrumentedProps for DOM core interfaces r=webidl,emilio

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustages on HTMLVideoElementBinding.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/376106d27ca394822f8fa873640e5f4da1331304
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=da5ea190fef6b405a8e80cc8ab4383c1fc3c89e9
• failure log: https://treeherder.mozilla.org/logviewer?job_id=430626625&repo=autoland&lineNumber=12436

[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -  In file included from UnifiedBindings10.cpp:119:
[task 2023-09-28T10:46:03.350Z] 10:46:03    ERROR -  ./HTMLVideoElementBinding.cpp:1016:27: error: use of undeclared identifier 'eUseCounter_HTMLVideoElement_playsInline'
[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -   1016 |           counter.emplace(eUseCounter_HTMLVideoElement_playsInline);
[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -        |                           ^
[task 2023-09-28T10:46:03.350Z] 10:46:03    ERROR -  ./HTMLVideoElementBinding.cpp:1025:31: error: use of undeclared identifier 'eUseCounter_HTMLVideoElement_disablePictureInPicture'; did you mean 'eUseCounter_HTMLDocument_exitPictureInPicture'?
[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -   1025 |               counter.emplace(eUseCounter_HTMLVideoElement_disablePictureInPicture);
[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -        |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-09-28T10:46:03.350Z] 10:46:03     INFO -        |                               eUseCounter_HTMLDocument_exitPictureInPicture

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/086fbeb80729
Part 1: Move InstrumentProps from HTMLDocument to Document r=webidl,emilio
https://hg.mozilla.org/integration/autoland/rev/821d140b48c1
Part 2: Add InstrumentedProps for DOM core interfaces r=webidl,emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/086fbeb80729
https://hg.mozilla.org/mozilla-central/rev/821d140b48c1