1855717 - Copying an autosuggested URL does not include protocol if using context menu options

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Found in

• Nightly 120.0a1;

Affected versions

• Nightly 120.0a1;
• Beta 119.0b2;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Firefox
2. Open https://musicbrainz.org .
3. Open a new tab.
4. Close the tab opened in step 2.
5. Type music and allow Firefox to autosuggest to musicbrainz.org/ .
6. Right-Click on the Address Bar, choose Select all.
7. Right-Click on the Address Bar, select Copy.
8. Right-Click on the Address Bar, select Paste.

Expected result

• Protocol information (https://) is included when using context menu options.

Actual result

• Protocol information (https://) is not included when using the context menu options.

Regression range

• Will look for one ASAP.

Additional notes

• Please note that selecting the autocompleted string with Ctrl+A or Triple-click and copying/pasting them via Ctrl+C/Ctrl+V, protocol information is successfully copied.

Comment 1

[BugBot [:suhaib / :marco]]

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Marco Bonardo [:mak]]

I suspect what differs between right click (not working as expected) VS CTRL+A (working as expected) is that the view is closed when the context menu opens, so we just end up copying the string in the input field.
We could probably check if the non-visible results are still relevant and copy the protocol from there.

Comment 3

[Daniel Bodea [:danibodea]]

It would appear that this issue is a very old regression.
I've attempted investigation and these are the best results possible using mozregression:
Tested mozilla-central build: 2019-10-28 (verdict: g)
Tested mozilla-central build: 2019-10-29 (verdict: b)

Comment 4

[Marc Seibert (:mseibert)]

Attachment: WIP: Bug 1855717 - Copying an autosuggested URL does not include protocol if using context menu options

Comment 5

[Marc Seibert (:mseibert)]

@mak I don't understand why in a previous updated the UrlbarView was closed on right click for the "paste and go" feature. "Paste And Go" seems to work fine even when not closing the View on right click https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarInput.sys.mjs#3113.

By removing this line, the context menu copy works as expected. The "toolbar copy button" still has the problem though, as again the View is closed before copy.

Comment 6

[Marc Seibert (:mseibert)]

Attachment: Bug 1855717 - Copy also from hidden results.r=adw

Comment 7

[Marc Seibert (:mseibert)]

I added a second patch that explores the other solution of fetching results from the hidden UrlbarView. This also allows using the copy button from the toolbar buttons.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc4db4866114
Copy also from hidden results.r=adw

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bc4db4866114

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-25 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 124.0a1 on Windows 10, macOS 12, Ubuntu 22.