1855731 - widget/gtk/nsAppShell.cpp:300: error: use of undeclared identifier 'WakeLockListener'

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Alexander Sergeyev]

Steps to reproduce:

Attempt to compile firefox-118 from sources with DBUS support being disabled.

Actual results:

Compile error: widget/gtk/nsAppShell.cpp:300:11: error: use of undeclared identifier 'WakeLockListener'.

The problem is caused by WakeLockListener being unconditionally used [1] while the corresponding header inclusion is covered by MOZ_ENABLE_DBUS check [2].

[1] https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/nsAppShell.cpp#l300
[2] https://hg.mozilla.org/mozilla-central/file/tip/widget/gtk/nsAppShell.cpp#l27

Expected results:

The build should have succeed.

Comment 1

[Alexander Sergeyev]

Attachment: avoid-wakelocklistener-when-dbus-disabled.patch

One way to fix the compile error

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Thanks for the patch Alexander. Do you mind to submit the patch to Phabricator so it can be reviewed and checked in?
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Use me as reviewer (r?stransky)
Thanks.

Comment 4

[Alexander Sergeyev]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #3)

Do you mind to submit the patch to Phabricator so it can be reviewed and checked in?

Tracked at: https://phabricator.services.mozilla.com/D191034

Comment 5

[Alexander Sergeyev]

Attachment: Bug 1855731 - Include WakeLockListener regardless of dbus support r?stransky

Clean up usage of WakeLockListener when building without dbus support
enabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec795d99e12a
Include WakeLockListener regardless of dbus support r=stransky

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ec795d99e12a