1855744 - Correct dynamic string for shopping opt-in card

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Emily McMinn :emcminn]

Attachment: Screen Shot 2023-09-28 at 10.17.53 AM.png

There's a small mismatch between the wording of the dynamic string on the onboarding card and the string that was handed off. We'll update it here.

Comment 1

[Emily McMinn :emcminn]

Attachment: Screen Shot 2023-09-28 at 10.18.36 AM.png

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1855744 - Update dynamic onboarding string in shopping sidebar

Comment 3

[Emily McMinn :emcminn]

We can't uplift strings to beta, so we'll use a workaround here to uplift the unlocalized string and then land the change as normal in 120. See bug 1855764

Comment 4

[Ed Lee :Mardak]

Is this something that needs to be uplifted or just fixed in 120?

Comment 5

[Punam Dahiya [:pdahiya]]

NI Product to help triage and update bug with the Fx119 uplift need for the fix Thanks!

Comment 6

[Ania]

Comment on attachment 9355620 [details]
Bug 1855744 - Update dynamic onboarding string in shopping sidebar

Beta/Release Uplift Approval Request

• User impact if declined: We have missed the old strings referring to the review checker as an experimental feature in the opt-in screen. The old strings are clunky enough to impact the opt-in rate into the experiment and skew the results, impacting future decisions on the review checker feature rollout.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change (despite being introduced past the code freeze) is not risky as we only expose en-US, en-GB, and en-CA users in the United States alone to this feature in 119.
• String changes made/needed: Yes
• Is Android affected?: No

Comment 7

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: Text update needed for Fx119 experiment

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/913187f6bdf5
Update dynamic onboarding string in shopping sidebar r=fluent-reviewers,omc-reviewers,pdahiya,shopping-reviewers,flod,jhirsch

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/913187f6bdf5

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9355620 [details]
Bug 1855744 - Update dynamic onboarding string in shopping sidebar

Approved for 119.0b4

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f112373c55ec

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest 119.0b4 as well as our latest Nightly 120.0a1 (2023-10-02).