1855746 - Read date-time options only once when creating DateTimeFormat objects

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement, P3)

Description

[André Bargull [:anba]]

Implement the changes from https://github.com/tc39/ecma402/pull/709.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1855746 - Part 1: Split LegacyInitializeObject into separate functions for Number- and DateTime-Format. r=dminor!

Split LegacyInitializeObject into two separate functions in preparation for the
next part.

Drive-by change:
Remove notes about constructors cached in "Utilities.js" which does no longer
apply to the current code.

Depends on D189537

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1855746 - Part 2: Read date-time options only once when creating DateTimeFormat objects. r=dminor!

Implements the changes from https://github.com/tc39/ecma402/pull/709.

The intl_DateTimeFormat self-hosted function is replaced with intl_CreateDateTimeFormat,
which implements the new CreateDateTimeFormat abstract operation from the spec.

intl_CreateDateTimeFormat calls into the existing InitializeDateTimeFormat function
to actually initialise the newly created date-time formatter.

Depends on D189538

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1855746 - Part 3: Update step numbers in CreateDateTimeFormat. r=dminor!

Updates spec step comments and variable names to match more recent spec draft texts.

The step comments probably no longer match the most recent spec, but it's currently
difficult to keep them updated, because there are multiple open spec PRs to refactor
this part of the spec.

Depends on D189539

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a208f8c06e1
Part 1: Split LegacyInitializeObject into separate functions for Number- and DateTime-Format. r=dminor
https://hg.mozilla.org/integration/autoland/rev/c1042546a44b
Part 2: Read date-time options only once when creating DateTimeFormat objects. r=dminor
https://hg.mozilla.org/integration/autoland/rev/c3b811d29db0
Part 3: Update step numbers in CreateDateTimeFormat. r=dminor

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3a208f8c06e1
https://hg.mozilla.org/mozilla-central/rev/c1042546a44b
https://hg.mozilla.org/mozilla-central/rev/c3b811d29db0