1855749 - ignorePunctuation collator option is locale-dependent

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect, P3)

Description

[André Bargull [:anba]]

Fix the issue reported in https://github.com/tc39/ecma402/issues/832.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1855749 - Part 1: Add intl::Collator::GetIgnorePunctuation(). r=dminor!

Add Collator::GetIgnorePunctuation() similar to the existing
Collator::GetCaseFirst() function.

Drive-by change:

• Remove unnecessary macro with an inline function.

Depends on D189542

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1855749 - Part 2: Add intl_isIgnorePunctuation self-hosting helper. r=dminor!

Adds intl_isIgnorePunctuation() and SharedIntlData::isIgnorePunctuation(),
which are both similar to the existing intl_isUpperCaseFirst() and
SharedIntlData::isUpperCaseFirst().

Depends on D189543

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1855749 - Part 3: Correctly handle ignorePunctuation option. r=dminor!

The default value for GetOption in InitializeCollator is changed from false
to undefined to avoid having to intl_isIgnorePunctuation in the constructor
function.

The corresponding spec PR is https://github.com/tc39/ecma402/pull/833, but
our behaviour is already not strictly spec-compliant as described in
https://github.com/tc39/ecma402/issues/832, so it seems reasonable to simply
implement the spec PR ahead of time. (We don't want to "fix" our implementation
to strictly follow the spec without the PR, because that could be web-incompatible
resp. at least disruptive for Thai users, which currently already get the expected
behaviour where punctuation characters are ignored in Thai.)

Depends on D189544

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca59d4521a8e
Part 1: Add intl::Collator::GetIgnorePunctuation(). r=dminor
https://hg.mozilla.org/integration/autoland/rev/a58b936add5f
Part 2: Add intl_isIgnorePunctuation self-hosting helper. r=dminor
https://hg.mozilla.org/integration/autoland/rev/bcf3b4652f99
Part 3: Correctly handle ignorePunctuation option. r=dminor

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ca59d4521a8e
https://hg.mozilla.org/mozilla-central/rev/a58b936add5f
https://hg.mozilla.org/mozilla-central/rev/bcf3b4652f99

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:anba, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[André Bargull [:anba]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #6)

The patch landed in nightly and beta is affected.
:anba, is this bug important enough to require an uplift?

No, uplift isn't required.