Closed Bug 1855916 Opened 1 year ago Closed 1 year ago

Validate that resources belong to the right device

Categories

(Core :: Graphics: WebGPU, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox-esr115 --- disabled
firefox118 --- disabled
firefox119 --- disabled
firefox120 --- fixed

People

(Reporter: nical, Assigned: nical)

References

Details

(Keywords: sec-other)

Upstream issue: https://github.com/gfx-rs/wgpu/issues/3927

We don't validate that resources being use together belong to the same device. When I originally filed this I thought that there was one registry per device, but it's actually per instance so we can end up potentially passing things from the wrong devices to the low level GPU APIs.

:nical: Given that you've indicated in the WebGPU team's private Matrix channel that this can perhaps be a security risk with resources potentially being shared between arbitrary pages:

  1. Is this a P1?
  2. Is this a sec-* issue?
Flags: needinfo?(nical.bugzilla)

Well, we don't have evidence that it is a security hazard (depends on what the driver does in this situation). I wouldn't be surprised that the bugs it creates on some drivers could be and others not. Now that the s-word has been put here, might as well mark it as a sec bug to avoid painting a bulls eye on it.

Group: core-security
Flags: needinfo?(nical.bugzilla)
Priority: P3 → P1
Group: core-security → gfx-core-security

Is bug 1856765 an example of this?

See Also: → 1856765
Depends on: 1857243
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Assignee: nobody → nical.bugzilla
Group: gfx-core-security → core-security-release

sec-other because we don't need to double-count sec-high bugs; this is the same issue as bug 1856765

Keywords: sec-other
Comment 1 is private: false
QA Whiteboard: [post-critsmash-triage]
Flags: qe-verify-

Bulk-unhiding security bugs fixed in Firefox 119-121 (Fall 2023). Use "moo-doctrine-subsidy" to filter

Group: core-security-release
You need to log in before you can comment on or make changes to this bug.