1855926 - crashreporter_unix_common.cpp: remove useless c_str()

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant. 

https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_unix_common.cpp#61
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_unix_common.cpp#65

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Comment 1

[abdullah.farwees]

UIDeleteFile(path); // Pass the string directly is the expected.

Also found that the method UIDeleteFile() which has the return type is "bool" but not used in caller functions. Does adding these lines would be helpful to check whether the deletion was successful or handle any errors?

bool success = UIDeleteFile(path);
if (!success) {
// Handle the error, if needed
}

line # 122 bool UIDeleteFile(const string& file) { return (unlink(file.c_str()) != -1); }

Comment 2

[Sylvestre Ledru [:Sylvestre]]

dunno but this isn't what this bug is about :)

please open a separate issue about it

Comment 3

[abdullah.farwees]

Regarding return value discussion, Opened a new issue here: https://bugzilla.mozilla.org/show_bug.cgi?id=1856273

Comment 4

[Andy]

How do I go about getting this ticket assigned to me?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

please submit a patch and it will be done automatically

Comment 6

[Andy]

Attachment: Bug 1855926 - Removed unnecessary c_str()'s r=andi

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eccda51a6f68
Removed unnecessary c_str()'s r=andi

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eccda51a6f68