1855950 - TestNrSocket::allow_ingress does not always set return parameter but uses it always

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Jens Stutte [:jstutte]]

We set *port_mapping_used only conditionally but then check it inconditionally while our caller did not initialize it, neither.

I wonder if rare intermittents like bug 1255293 might stem from this.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1855950 - TestNrSocket::allow_ingress should not rely on *port_mapping_used being initialized by the caller. r?bwc

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91bd2248667d
TestNrSocket::allow_ingress should not rely on *port_mapping_used being initialized by the caller. r=bwc

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for GTest failure on TestNrSocketTest

Backout link: https://hg.mozilla.org/integration/autoland/rev/0d6670d3c6f98f10927a7726d656e81773e9e729
Log link: https://treeherder.mozilla.org/logviewer?job_id=430794732&repo=autoland&lineNumber=9101

Comment 4

[Jens Stutte [:jstutte]]

Hi :bwc, please note my question in phabricator, thank you!

Comment 5

[Jens Stutte [:jstutte]]

(Answer in phab, thanks.)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b51c7a8a8ee
TestNrSocket::allow_ingress should not rely on *port_mapping_used being initialized by the caller. r=bwc

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2b51c7a8a8ee