1855986 - ICU update script no longer works

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[André Bargull [:anba]]

Bug 1852210 broke the ICU update script.

STR:

cd $MOZ/intl
PYTHONPATH=../python/mozbuild/ ./update-icu.sh https://github.com/unicode-org/icu.git release-73-1

Output:

...
Running ICU configure...                                                                                                                                                                                                             
Running ICU make...                                                                                                                                                                                                                  
Error running "make --jobs=4 --output-sync" in directory /tmp/icu-obj-rumu4ck4                                                                                                                                                       
    See output in /tmp/icu-make3eepx_37

And in "/tmp/icu-make3eepx_37":

/home/andre/hg/mozilla-central/intl/icu/source/i18n/number_decimalquantity.cpp:19:10: fatal error: double-conversion/double-conversion.h: No such file or directory
   19 | #include "double-conversion/double-conversion.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Furthermore bug 1852210 incorrectly modified imported files:

:~/hg/mozilla-central/intl$ hg st .
M icu/source/i18n/sources.txt
? icu/source/i18n/double-conversion-bignum-dtoa.cpp
? icu/source/i18n/double-conversion-bignum-dtoa.h
? icu/source/i18n/double-conversion-bignum.cpp
? icu/source/i18n/double-conversion-bignum.h
? icu/source/i18n/double-conversion-cached-powers.cpp
? icu/source/i18n/double-conversion-cached-powers.h
? icu/source/i18n/double-conversion-diy-fp.h
? icu/source/i18n/double-conversion-double-to-string.cpp
? icu/source/i18n/double-conversion-double-to-string.h
? icu/source/i18n/double-conversion-fast-dtoa.cpp
? icu/source/i18n/double-conversion-fast-dtoa.h
? icu/source/i18n/double-conversion-ieee.h
? icu/source/i18n/double-conversion-string-to-double.cpp
? icu/source/i18n/double-conversion-string-to-double.h
? icu/source/i18n/double-conversion-strtod.cpp
? icu/source/i18n/double-conversion-strtod.h
? icu/source/i18n/double-conversion-utils.h
? icu/source/i18n/double-conversion.h

Unused ICU source files should be recorded in "intl/icu_sources_data.py" instead of manually deleting them.

Note: hg st shows some additional changes after reimporting ICU 73.1, but that's because of bug 1855981.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852210

:sergesanspaille, since you are the author of the regressor, bug 1852210, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox120 (nightly). However, the bug still isn't assigned.

:marco, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[[:sergesanspaille]]

Attachment: Bug 1855986 - Rearrange icu update script to take into account double-conversion vendoring r=anba

Since Bug 1852210 we use a single version of double-conversion: the one vendored in mfbt.

As a consequence, setup the build environment used in
intl/icu_sources_data.py to use that version instead of the bundled one.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1855986: Don't attempt to use in-tree double-conversion for ICU standalone builds. r=sergesanspaille!

Updates the ICU patch "double-conversion.diff" to only use the in-tree copy of
double-conversion when building Firefox/SpiderMonkey. Standalone ICU builds
instead use the ICU copy of double-conversion. Standalone ICU builds happen
when running "intl/icu_sources_data.py" and when converting the in-tree
little-endian ICU data file to the big-endian format.

JS_HAS_INTL_API is used to detect how ICU is built: When building ICU as part
of Firefox/SpiderMonkey, JS_HAS_INTL_API is guaranteed to be set, whereas in
standalone ICU builds JS_HAS_INTL_API isn't defined.

After applying the updated "double-conversion.diff" patch, ICU was reimported
to restore the previously deleted double-conversion sources files from ICU.

Depends on D190791

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f4fc4b6cc05
Don't attempt to use in-tree double-conversion for ICU standalone builds. r=sergesanspaille,glandium

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8f4fc4b6cc05