1856018 - Make invalid forgiving selectors serialize.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1856018 - Make forgiving selectors serialize. r=dshin,#style,#layout

As per resolution in https://github.com/w3c/csswg-drafts/issues/8356

Safari already does this. Expand the tests they tweaked to be useful
again (test that when non-forgiving parsing is used, then the selector
is invalid).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21db15048e15
Make forgiving selectors serialize. r=dshin

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42314 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures/crashes.

Backout link: https://hg.mozilla.org/integration/autoland/rev/63d2325d873c35dfbe038b86c59064ad20ba93e8

Push with failures

Failure log bustage ->

Failure log mochitest->

Failure log wpt->

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb6f84a4847
Make forgiving selectors serialize. r=dshin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ac279a74f07
Fix another test that I missed.

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2cb6f84a4847
https://hg.mozilla.org/mozilla-central/rev/7ac279a74f07

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb6f84a4847
Make forgiving selectors serialize. r=dshin

== Change summary for alert #39879 (as of Tue, 10 Oct 2023 10:37:41 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	perf_reftest_singletons nth-index-1.html	linux1804-64-shippable-qr	e10s fission stylo webrender	1.80 -> 1.70
6%	perf_reftest_singletons nth-index-2.html	linux1804-64-shippable-qr	e10s fission stylo webrender	1.80 -> 1.70
5%	perf_reftest_singletons nth-index-1.html	linux1804-64-shippable-qr	e10s fission stylo webrender	1.78 -> 1.70

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39879