Make invalid forgiving selectors serialize.
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: perf-alert)
Attachments
(1 file)
|
Assignee | |
Comment 2•9 months ago
|
||
As per resolution in https://github.com/w3c/csswg-drafts/issues/8356
Safari already does this. Expand the tests they tweaked to be useful
again (test that when non-forgiving parsing is used, then the selector
is invalid).
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21db15048e15 Make forgiving selectors serialize. r=dshin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42314 for changes under testing/web-platform/tests
|
||
Comment 5•9 months ago
|
||
Backed out for causing multiple failures/crashes.
Backout link: https://hg.mozilla.org/integration/autoland/rev/63d2325d873c35dfbe038b86c59064ad20ba93e8
Upstream PR was closed without merging
|
|
Assignee | |
Updated•9 months ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cb6f84a4847 Make forgiving selectors serialize. r=dshin
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/7ac279a74f07 Fix another test that I missed.
|
||
Comment 9•9 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2cb6f84a4847
https://hg.mozilla.org/mozilla-central/rev/7ac279a74f07
Upstream PR merged by moz-wptsync-bot
|
||
Comment 11•8 months ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cb6f84a4847
Make forgiving selectors serialize. r=dshin
== Change summary for alert #39879 (as of Tue, 10 Oct 2023 10:37:41 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | perf_reftest_singletons nth-index-1.html | linux1804-64-shippable-qr | e10s fission stylo webrender | 1.80 -> 1.70 |
| 6% | perf_reftest_singletons nth-index-2.html | linux1804-64-shippable-qr | e10s fission stylo webrender | 1.80 -> 1.70 |
| 5% | perf_reftest_singletons nth-index-1.html | linux1804-64-shippable-qr | e10s fission stylo webrender | 1.78 -> 1.70 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39879
Description
•