1856060 - Shopping card vertical padding is too small (should be 12px instead of 8px)

Status: VERIFIED FIXED

(Firefox :: Shopping, defect)

Description

[:Gijs (he/him)]

We use 8px, and that is correct for the gap between different items inside the card, but the card's outer padding should be 12px.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1856060 - increase shopping card vertical padding, r?#shopping-reviewers

Comment 2

[:Gijs (he/him)]

Talking to Julian, there are 2 other things that UX would like to change here:

• the expandable headers with a button to the right (end) hand side should have 10px vertical padding and 10px end padding because the button otherwise makes the header "too tall" (or some alternative CSS solution that accomplishes the same thing, ie "pulls in" the vertical size of the header, to match the size it would have without the button, as well as "pulling it" closer to the end of the row)
• the "show more"/"show less" button should have an 8px gap above it instead of 12px.

I'll move the second one to bug 1856057.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0623f14a9743
increase shopping card vertical padding, r=shopping-reviewers,niklas

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0623f14a9743

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1856060 - increase shopping card vertical padding, r?#shopping-reviewers

Feedback from UX was that the button should not impact the vertical spacing of
the header text in the accordion cards, so this makes the button abspos
so it stops impacting the sizing of its container.

Original Revision: https://phabricator.services.mozilla.com/D189765

Comment 6

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: yes
• Fix verified in Nightly: no
• Explanation of risk level: CSS only patch
• Code covered by automated testing: no
• User impact if declined: visual design of review checker looks unpolished
• Risk associated with taking this patch: low
• String changes made/needed: no
• Steps to reproduce for manual QE testing: check the issues in comment 0 and 2 are addressed
• Is Android affected?: no

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9356422 [details]
Bug 1856060 - increase shopping card vertical padding, r?#shopping-reviewers

Approved for 119.0b5

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/48d91004bc44

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 120.0a1 (2023-10-03) and our latest beta 119.0b5.