1856140 - Discrepancies in %-escaping of username/password in URL

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Jonathan Kew [:jfkthame]]

I noticed that we have some URL test failures that occur because the set of characters that are percent-escaped in the username/password fields of the URL don't match WPT expectations.

Checking the URL spec it seems that both username and password should depend on "the userinfo percent-encode set", so would share the same escaping behavior. However, in nsEscape.cpp they end up with slightly different encode sets, and don't match what the URL standard specifies. In particular,

• vertical bar | should be encoded
• period . and apostrophe ' should not be encoded

Adjusting these encode-sets to align with the spec will result in several new WPT passes, so unless there's some legacy-compat reason we can't do so, I suggest we should make this change.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1856140 - Update set of url-escaped chars used for username/password to match WPT test expectations. r=#necko-reviewers

Depends on D189701

Comment 2

[Jonathan Kew [:jfkthame]]

Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=07cc427e2d9c90a69bcbb6a852b7b6b5dabf114f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a54caa9b328
Update set of url-escaped chars used for username/password to match WPT test expectations. r=necko-reviewers,jesup

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6a54caa9b328